outmoded · FennNaten · Apr 20, 2015 · Apr 20, 2015 · Apr 20, 2015 · Apr 21, 2015
diff --git a/Makefile b/Makefile
@@ -1,7 +1,7 @@
 test:
 	@node node_modules/lab/bin/lab -a code
 test-cov:
-	@node node_modules/lab/bin/lab -a code -t 100 -L
+	@node node_modules/lab/bin/lab -a code -t 100 -Lv
 test-cov-html:
 	@node node_modules/lab/bin/lab -a code -r html -o coverage.html
 

diff --git a/lib/index.js b/lib/index.js
@@ -2,19 +2,23 @@
 
 var Hapi = require('hapi');
 var Version = require('./version');
-
+var Private = require('./private');
 
 // Declare internals
 
 var internals = {};
 
 
-exports.init = function (port, next) {
+exports.init = function (config, next) {
+
+    if (!config || typeof (config) !== 'object'){
+        return next(new Error('mandatory configuration object not provided'));
+    }
 
     var server = new Hapi.Server();
-    server.connection({ port: port });
+    server.connection({ port: config.port });
 
-    server.register(Version, function (err) {
+    server.register([Version, {register: Private, options: {users: config.users}}], function (err) {
 
         if (err) {
             return next(err);

diff --git a/lib/private.js b/lib/private.js
@@ -0,0 +1,66 @@
+// Load modules
+
+var Basic = require('hapi-auth-basic');
+
+// Declare internals
+
+var internals = {
+    response: {
+        template: '<html><head><title>private page</title></head><body>Greetings %username%. Welcome to the private section.</body></html>',
+        generate: function (username){
+
+            return this.template.replace('%username%', username);
+        }
+    },
+    authStrategyName: 'private-basic',
+    authValidate: function(users, username, password, callback) {
+
+        var candidateUser = users.filter(function(userObject){
+
+            return userObject.username === username && userObject.password === password;
+        });
+        var user = candidateUser.length ? candidateUser[0] : null;
+        if (!user) {
+            return callback(null, false);
+        }
+        return callback(null, true, {username: user.username});
+    }
+};
+
+
+exports.register = function (server, options, next) {
+
+    var users = options.users;
+    if (users === null || users === undefined){
+        return next(new Error('private plugin requires users to be provided as option'));
+    }
+    if (!users.filter || !typeof (users.filter) === 'function'){
+        return next(new Error('provided users option must have a filter method'));
+    }
+
+    server.register(Basic, function(err){
+        if (err) {
+            return next(err);
+        }
+        server.auth.strategy(internals.authStrategyName, 'basic', { validateFunc: internals.authValidate.bind(internals, users) });
+
+        server.route({
+            method: 'GET',
+            path: '/private',
+            config: {
+                auth: internals.authStrategyName,
+                description: 'Returns a welcome message if user successfully authenticated via basic auth',
+                handler: function (request, reply) {
+
+                    return reply(internals.response.generate(request.auth.credentials.username));
+                }
+            }
+        });
+
+        return next();
+    });
+};
+
+exports.register.attributes = {
+    name: 'private'
+};
diff --git a/lib/start.js b/lib/start.js
@@ -2,14 +2,20 @@
 
 var Hoek = require('hoek');
 var Server = require('./index');
+var Users = require('./users.json');
 
 
 // Declare internals
 
-var internals = {};
+var internals = {
+    config: {
+        port: 8000,
+        users: Users
+    }
+};
 
 
-Server.init(8000, function (err, server) {
+Server.init(internals.config, function (err, server) {
 
     Hoek.assert(!err, err);
     console.log('Server started at: ' + server.info.uri);

diff --git a/lib/users.json b/lib/users.json
@@ -0,0 +1,10 @@
+[
+    {
+        "username": "dummy",
+        "password": "12345678"
+    },
+    {
+        "username": "janedoe",
+        "password": "azerty"
+    }
+]
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "hueniversity",
-  "version": "0.0.3",
+  "version": "0.0.4",
   "description": "Community learning experiment",
   "main": "lib/index.js",
   "repository": {
@@ -19,10 +19,11 @@
   "homepage": "https://github.com/hueniverse/hueniversity",
   "dependencies": {
     "hapi": "8.x.x",
+    "hapi-auth-basic": "2.x.x",
     "hoek": "2.x.x"
   },
   "scripts": {
-    "test": "node node_modules/lab/bin/lab -a code -t 100 -L",
+    "test": "node node_modules/lab/bin/lab -a code -t 100 -Lv",
     "start": "node lib/start.js"
   },
   "devDependencies": {

diff --git a/test/index.js b/test/index.js
@@ -5,19 +5,29 @@ var Code = require('code');
 var Lab = require('lab');
 var Hueniversity = require('../lib');
 var Version = require('../lib/version');
+var Users = require('../lib/users.json');
 
 
 // Test shortcuts
 
 var lab = exports.lab = Lab.script();
-var describe = lab.experiment;
 var expect = Code.expect;
 var it = lab.test;
 
+it('throws if configuration is null', function(done){
+
+    Hueniversity.init(null, function (err, server) {
+
+        expect(err).to.exist();
+        expect(err.message).to.equal('mandatory configuration object not provided');
+
+        done();
+    });
+});
 
 it('starts server and returns hapi server object', function (done) {
 
-    Hueniversity.init(0, function (err, server) {
+    Hueniversity.init({port: 0, users: Users}, function (err, server) {
 
         expect(err).to.not.exist();
         expect(server).to.be.instanceof(Hapi.Server);
@@ -28,7 +38,7 @@ it('starts server and returns hapi server object', function (done) {
 
 it('starts server on provided port', function (done) {
 
-    Hueniversity.init(5000, function (err, server) {
+    Hueniversity.init({port: 5000, users: Users}, function (err, server) {
 
         expect(err).to.not.exist();
         expect(server.info.port).to.equal(5000);
@@ -50,7 +60,7 @@ it('handles register plugin errors', { parallel: false }, function (done) {
         name: 'fake version'
     };
 
-    Hueniversity.init(0, function (err, server) {
+    Hueniversity.init({port: 0, users: Users}, function (err, server) {
 
         expect(err).to.exist();
         expect(err.message).to.equal('register version failed');

diff --git a/test/private.js b/test/private.js
@@ -0,0 +1,140 @@
+// Load modules
+
+var Code = require('code');
+var Lab = require('lab');
+var Hueniversity = require('../lib');
+var Basic = require('hapi-auth-basic');
+var Hoek = require('hoek');
+
+// Declare internals
+
+var internals = {};
+
+// Test shortcuts
+
+var lab = exports.lab = Lab.script();
+var describe = lab.experiment;
+var expect = Code.expect;
+var it = lab.test;
+var beforeEach = lab.beforeEach;
+var afterEach = lab.afterEach;
+
+
+describe('/private', function () {
+
+
+    it('returns unauthorized if user doesn\'t exist', function (done) {
+
+        Hueniversity.init({port: 0, users: internals.getTestUsers()}, function (err, server) {
+
+            expect(err).to.not.exist();
+
+            var username = 'test';
+
+            var password = '12345678';
+            var request = { method: 'GET', url: '/private', headers: { authorization: internals.header(username, password) } };
+
+            server.inject(request, function (res) {
+
+                expect(res.statusCode).to.equal(401);
+
+                server.stop(done);
+            });
+        });
+    });
+
+    it('returns unauthorized if user exist but password is wrong', function (done) {
+
+        Hueniversity.init({port: 0, users: internals.getTestUsers()}, function (err, server) {
+
+            expect(err).to.not.exist();
+
+            var username = 'jdoe';
+            var password = '12345678';
+            var request = { method: 'GET', url: '/private', headers: { authorization: internals.header(username, password) } };
+
+            server.inject(request, function (res) {
+
+                expect(res.statusCode).to.equal(401);
+
+                server.stop(done);
+            });
+        });
+    });
+
+    it('returns greetings if user exists and password is ok', function (done) {
+
+        Hueniversity.init({port: 0, users: internals.getTestUsers()}, function (err, server) {
+
+            expect(err).to.not.exist();
+
+            var username = 'jdoe';
+            var password = 'qwerty';
+            var request = { method: 'GET', url: '/private', headers: { authorization: internals.header(username, password) } };
+
+            server.inject(request, function (res) {
+
+                expect(res.statusCode).to.equal(200);
+                expect(res.result).to.equal('<html><head><title>private page</title></head><body>Greetings jdoe. Welcome to the private section.</body></html>');
+
+                server.stop(done);
+            });
+        });
+    });
+
+    it('error bubbles up if basic auth plugin registration throws', { parallel: false }, function (done) {
+
+        var orig = Basic.register;
+        Basic.register = function (server, options, next) {
+
+            Basic.register = orig;
+            return next(new Error('register basic auth failed'));
+        };
+
+        Basic.register.attributes = {
+            name: 'fake basic auth'
+        };
+
+        Hueniversity.init({port: 0, users: internals.getTestUsers()}, function (err, server) {
+
+            expect(err).to.exist();
+            expect(err.message).to.equal('register basic auth failed');
+
+            done();
+        });
+    });
+
+    it('throws an error if users aren\'t provided', function(done){
+
+        Hueniversity.init({port: 0, users: null}, function (err, server) {
+
+            expect(err).to.exist();
+            expect(err.message).to.equal('private plugin requires users to be provided as option');
+
+            done();
+        });
+    });
+
+    it('throws an error if provided users object doesn\'t have filter method', function(done){
+
+        Hueniversity.init({port: 0, users: {}}, function (err, server) {
+
+            expect(err).to.exist();
+            expect(err.message).to.equal('provided users option must have a filter method');
+
+            done();
+        });
+    });
+});
+
+internals.header = function (username, password) {
+
+    return 'Basic ' + (new Buffer(username + ':' + password, 'utf8')).toString('base64');
+};
+
+internals.testUsers = [{username: 'jdoe', password: 'qwerty'}];
+
+internals.getTestUsers = function(){
+
+    return Hoek.clone(internals.testUsers);
+};
diff --git a/test/version.js b/test/version.js
@@ -3,7 +3,8 @@
 var Code = require('code');
 var Lab = require('lab');
 var Pkg = require('../package.json');
-var Server = require('../lib');
+var Hueniversity = require('../lib');
+var Users = require('../lib/users.json');
 
 
 // Test shortcuts
@@ -18,7 +19,7 @@ describe('/version', function () {
 
     it('returns the version from package.json', function (done) {
 
-        Server.init(0, function (err, server) {
+        Hueniversity.init({port: 0, users: Users}, function (err, server) {
 
             expect(err).to.not.exist();