Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on-media-delete 추가 부탁드립니다. #92

Closed
cmd-shift-s opened this issue Dec 16, 2015 · 3 comments
Closed

on-media-delete 추가 부탁드립니다. #92

cmd-shift-s opened this issue Dec 16, 2015 · 3 comments

Comments

@cmd-shift-s
Copy link

안녕하세요.

imageUpload를 보면서 혼자 수정을 했는데요. 조금 이상하게 한것같아요;

    if (angular.isDefined($attrs.onMediaDelete)) {
      callbacks.onMediaDelete = function(target) {
        var element = {
          target: target
        };
        $scope.mediaDelete({target:element, editable: $scope.editable});
      }
    }

이게 target을 바로 넘기니까요. dom을 바로 넘긴다고 에러가 나더라구요.

Error: $parse:isecdom Referencing a DOM node in Expression

그래서 json으로 한번 감싸니까 넘어가져서 결과를 잘 받긴 하더라구요.

저는 여기까지 인것 같아요.. 잘 부탁드립니다 ~

outsideris added a commit that referenced this issue Jan 6, 2016
@outsideris
Copy link
Owner

@gongzza I added on-media-delete. Please check it and tell me what you think about this aproach.
Angular prohibit passing DOM into angular expression.

@cmd-shift-s
Copy link
Author

@outsideris 안녕하세요 ~ 추가해주셔서 감사합니다 ~ 제가 답변이 많이 늦었네요 ㅠ
제 생각에는 완벽한 것 같아요 ㅎㅎ 감사합니다 ~

@outsideris
Copy link
Owner

@gongzza Thank you for confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants