Make prototype pollution attacks harder in most Bun APIs that accept objects #14119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes GHSA-5jqh-3v22-8jgj
This makes it so that in most natively-implemented APIs, we ignore prototype chains when calling getters on objects. We deliberately continue to consult prototype chains for Web APIs and node APIs because that would be a clearly breaking change.
This might be a breaking change as-is.
There are probably a few more spots in Bun APIs where we should do this that we aren't, like the shell (which has a JS wrapper).
Let's see if this causes any non-flaky test failures
How did you verify your code works?
There is a test for GHSA-5jqh-3v22-8jgj