DNS fixes #15864
Merged
DNS fixes #15864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heimskr
requested review from
a team and
zackradisic
and removed request for
a team
Jarred-Sumner
requested review from
a team and
cirospaciari
and removed request for
zackradisic and
a team
Jarred-Sumner
requested changes
Dec 31, 2024
There was a problem hiding this comment.
After each request is sent or fulfilled, we should check if there are still any in-flight requests and if there are no longer any, then cancel the timer so that we don't keep the process alive longer than necessary.
A helper method for updating the timer state would be a good idea I think
| return globalThis.throwInvalidArgumentType("setServers", "triple", "array"); | ||
| } | ||
|
|
||
| const family = JSValue.getIndex(triple, globalThis, 0).toInt32(); |
There was a problem hiding this comment.
This would be a great use-case for the bindings generator @paperdave
Co-authored-by: Jarred Sumner <[email protected]>
heimskr
force-pushed
the
kai/dns-test-fixes
branch
from
1f98482 to
7a7c60c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds some DNS tests and the changes that caused them to start passing.
How did you verify your code works?
Added tests from Node.