-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow IncomingRequest.req to be overwritten. #4154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarred-Sumner
approved these changes
Aug 15, 2023
❌ @paperdave 1 files with test failures on linux-x64:
|
❌ @paperdave 2 files with test failures on linux-x64-baseline:
|
❌ @paperdave 4 files with test failures on bun-darwin-aarch64:
|
❌ @paperdave 7 files with test failures on bun-darwin-x64-baseline:
|
Jarred-Sumner
requested changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix the test
Closed
paperclover
force-pushed
the
dave/req-req-not-readonly
branch
from
August 16, 2023 02:04
208cda0
to
2ab9966
Compare
paperclover
force-pushed
the
dave/req-req-not-readonly
branch
from
August 17, 2023 21:49
2ab9966
to
5d387a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #4141
How did you verify your code works?