Add supports for Symfony 4 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcg-web
force-pushed
the
symfony_4
branch
2 times, most recently
from
c000f27 to
f60fb9f
Compare
mcg-web
force-pushed
the
symfony_4
branch
2 times, most recently
from
86834ab to
22d3b15
Compare
renatomefi
reviewed
Nov 16, 2017
| @@ -15,27 +19,35 @@ matrix: | |||
| - php: 5.5 | |||
| env: SYMFONY_VERSION=2.8.* | |||
| - php: 5.6 | |||
| env: SYMFONY_VERSION=3.0.* | |||
| - php: 7.0 | |||
| env: SYMFONY_VERSION=3.1.* | |||
.travis.yml
Outdated
| env: SYMFONY_VERSION=3.2.* | ||
| - php: hhvm | ||
| env: PHP_CS_FIXER=true | ||
| - php: 7.1 |
There was a problem hiding this comment.
How about adding prefer-lowest here as well?
There was a problem hiding this comment.
prefer-lowest fails because of phpunit 4, I'll added in a next PR
There was a problem hiding this comment.
If the problem is only the TestCase class you can set the minimum phpunit to version 4.8.35
https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-4.8.md
mcg-web
force-pushed
the
symfony_4
branch
2 times, most recently
from
b5f9815 to
e91486f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.