Support FQCN services names #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Liinkiing thank you for contributing. This look good to me for the meantime but can you add a test to cover this case please? |
|
@mcg-web Done! |
mcg-web
approved these changes
Jul 25, 2018
|
Thank you @Liinkiing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#14
I've seen that in the issue maybe you wanted to make something more advanced, using the compiler pass because the regex will not be sufficient anymore. But with the regex, it would actually fail if you do not specify a valid service name. Maybe you really don't want at the moment to use regex, but I've wanted to submit this PR anyway to see if you will be okay to use that regex in the meantime. I don't know enough how works the compiler pass so I could not try to make something more advanced, but I'll totally understand if you don't want to support FQCN services names with a simple regex ! 👍