RegisterCraftingBench #1830
Draft
RegisterCraftingBench #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created an export to remotely register new crafting benches (like possible with RegisterStash).
|
Through testing, I just found an error where, due to the await, the inventory does not ready in time on the client side. Simply corrected by changing the callback. |
iampitchou
reviewed
Dec 4, 2024
| createCraftingBench(id, data) | ||
| end) | ||
|
|
||
| lib.callback('ox_inventory:getCraftingBenches', false, function(data) for id, data in pairs(data) do createCraftingBench(id, data) end end) |
There was a problem hiding this comment.
I would rename the var data in the loop
Suggested change
| lib.callback('ox_inventory:getCraftingBenches', false, function(data) for id, data in pairs(data) do createCraftingBench(id, data) end end) | |
| lib.callback('ox_inventory:getCraftingBenches', false, function(data) for id, bench in pairs(data) do createCraftingBench(id, bench) end end) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created the
RegisterCraftingBenchexport server-side so that developers can create benches dynamically in the same was as stashes. I didn't concern myself with security for the client event as the main scripts code handles distance checks and checking if a bench exists.