Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for entity lockdown with dumpsters #1875

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Conversation

Scullyy
Copy link
Contributor

@Scullyy Scullyy commented Jan 26, 2025

This implementation has been tested extensively and worked flawlessly during all tests. The only limitation is that dumpsters need to be frozen when nearby to maintain a consistent position across clients. Given that dumpsters in the game tend to move like cardboard boxes, this could also be considered an improvement haha.

If anyone has suggestions to improve this further, feedback is welcome!

@Scullyy
Copy link
Contributor Author

Scullyy commented Jan 26, 2025

Showcase of it working: https://streamable.com/crqll0

@Scullyy Scullyy force-pushed the main branch 2 times, most recently from 3638e7f to 182bf4c Compare January 27, 2025 02:31
From personal tests this has worked perfectly, the only downside is dumpsters need to be frozen when nearby to maintain a persistent position across clients. If anyone has any ideas on how to improve this further I'm open to suggestions.
Copy link
Member

@thelindat thelindat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be tied behind a convar rather than replacing the existing system. Neither is ideal anyway.

server.lua Show resolved Hide resolved
server.lua Show resolved Hide resolved
@Scullyy
Copy link
Contributor Author

Scullyy commented Jan 27, 2025

If you would like me to rename the convar just let me know, I wasn't really sure what to name it but considered this "fitting".

@Scullyy Scullyy requested a review from thelindat January 27, 2025 12:10
@thelindat
Copy link
Member

If you would like me to rename the convar just let me know, I wasn't really sure what to name it but considered this "fitting".

Probably something like inventory:networkdumpsters.

@Scullyy
Copy link
Contributor Author

Scullyy commented Jan 30, 2025

If you would like me to rename the convar just let me know, I wasn't really sure what to name it but considered this "fitting".

Probably something like inventory:networkdumpsters.

done

@thelindat thelindat merged commit b5b6912 into overextended:main Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants