feat: add atlas pull
#29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @regisb |
OmarIthawi
commented
Jan 7, 2024
tutorcredentials/templates/credentials/build/credentials/Dockerfile
Outdated
Show resolved
Hide resolved
OmarIthawi
force-pushed
the
atlas
branch
2 times, most recently
from
eb43ae9 to
30cd188
Compare
|
@Faraz32123 this is ready for review. I've tested it on my devstack and the Please let me know if there's anything I need to change. |
Faraz32123
reviewed
Jan 15, 2024
There was a problem hiding this comment.
LGTM! Thanks for your contribution @OmarIthawi.
Forgot to submit review before merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atlas pull in the most simple form. Depends on overhangio/tutor#964.
This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.