This repository has been archived by the owner on Aug 6, 2021. It is now read-only.
add ioredis maxRetriesPerRequest #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryoswald
reviewed
Oct 7, 2019
config/settings.defaults.coffee
Outdated
| redisOptions: | ||
| keepAlive: 100 | ||
|
|
||
| maxRetriesPerRequest: 0 |
There was a problem hiding this comment.
shall we have the default at 20 with an env MAX_RETRIES_PER_REQUEST passed through to set this?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Try out the ioredis maxRetriesPerRequest = 0 option, to see if improves behaviour where docupdater gets into a bad state.
Having thought about this over the weekend, it is not safe to deploy this to all docupdaters because we can't predict how it will behave in production if there is an error.
@mans0954 I talked to Henry about setting up some kind of canary deploy in a simple way where we can just have one docupdater running with this option. Could you help with that? Thanks.
Screenshots
NA
Related Issues / PRs
redis/ioredis#965
Review
Small change. I have removed the old keepAlive options which have no effect under
redisOptions:which only applies toclusterconfigurations. If we want to add these back we should just use thekeepAliveoption at the top level, withmaxRetriesPerRequestPotential Impact
High - don't deploy.
Manual Testing Performed
I tried this locally restarting redis or pausing it while everything was running but I couldn't trigger anything that looked like
maxRetriesPerRequestwas having an effect.Accessibility
NA
Deployment
Don't deploy - PR for future use only.
Deployment Checklist
Metrics and Monitoring
Docupdater metrics/logs in stackdriver.
Who Needs to Know?
cc @gh2k @henryoswald @jdleesmiller