Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

Router #76

Merged
merged 3 commits into from
Aug 27, 2018
Merged

Router #76

merged 3 commits into from
Aug 27, 2018

Conversation

d33d33
Copy link
Contributor

@d33d33 d33d33 commented Jul 4, 2018

No description provided.

@d33d33 d33d33 self-assigned this Jul 4, 2018
@d33d33 d33d33 requested a review from FlorentinDUBOIS July 4, 2018 17:02
src/config.rs Outdated
@@ -544,6 +546,16 @@ fn load_path<P: AsRef<Path>>(file_path: P, config: &mut Config) -> Result<(), Co
try!(cast::u64(timeout).map_err(|_| format!("parameters.timeout is invalid")));
config.parameters.timeout = timeout;
}
if !doc["parameters"]["router-parallel"].is_badvalue() {
let router_parallel = try!(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ? instead of try!

src/config.rs Outdated
.ok_or("parameters.router-parallel should be a number")
);
let router_parallel =
try!(cast::u64(router_parallel).map_err(|_| format!("parameters.router-parallel is invalid")));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ? instead of try!

src/main.rs Outdated
});
}));
}
let mut router = router::Router::new(&config.sinks, &config.parameters, &config.labels); // FIXME
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why FIXME ?

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jul 17, 2018

CDS Report build-rust-multi#92.0 ✘

  • Cargo
    • CentOS:6 ✘
    • CentOS:7 ✘
    • Debian:Jessie -
    • Debian Stretch -
    • Debian:Wheezy -
    • Docker package ✘
    • Ubuntu:Bionic ✘
    • Ubuntu:Trusty -
    • Ubuntu:Vivid -
    • Ubuntu:Xenial -
    • Ubuntu:Yakkety -

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jul 17, 2018

CDS Report build-rust-multi#94.0 ✘

  • Cargo
    • CentOS:6 ✘
    • CentOS:7 -
    • Debian:Jessie -
    • Debian Stretch -
    • Debian:Wheezy -
    • Docker package ✔
    • Ubuntu:Bionic -
    • Ubuntu:Trusty -
    • Ubuntu:Vivid -
    • Ubuntu:Xenial -
    • Ubuntu:Yakkety -

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jul 18, 2018

CDS Report build-deb#96.0 ✘

  • Stage 1
    • Debian:Jessie ✘
    • Debian:Stretch ✘
    • Debian:Wheezy ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jul 18, 2018

CDS Report build-deb#97.0 ✘

  • Stage 1
    • Debian:Jessie ✘
    • Debian:Stretch ✘
    • Debian:Wheezy ✘

@d33d33 d33d33 merged commit b8b134f into master Aug 27, 2018
@d33d33 d33d33 deleted the router branch August 27, 2018 11:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants