This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
Router #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorentinDUBOIS
approved these changes
Jul 4, 2018
src/config.rs
Outdated
@@ -544,6 +546,16 @@ fn load_path<P: AsRef<Path>>(file_path: P, config: &mut Config) -> Result<(), Co | |||
try!(cast::u64(timeout).map_err(|_| format!("parameters.timeout is invalid"))); | |||
config.parameters.timeout = timeout; | |||
} | |||
if !doc["parameters"]["router-parallel"].is_badvalue() { | |||
let router_parallel = try!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use ? instead of try!
src/config.rs
Outdated
.ok_or("parameters.router-parallel should be a number") | ||
); | ||
let router_parallel = | ||
try!(cast::u64(router_parallel).map_err(|_| format!("parameters.router-parallel is invalid"))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use ? instead of try!
src/main.rs
Outdated
}); | ||
})); | ||
} | ||
let mut router = router::Router::new(&config.sinks, &config.parameters, &config.labels); // FIXME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why FIXME ?
StevenLeRoux
approved these changes
Jul 4, 2018
CDS Report build-rust-multi#92.0 ✘
|
CDS Report build-rust-multi#94.0 ✘
|
CDS Report build-deb#96.0 ✘
|
CDS Report build-deb#97.0 ✘
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.