Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): use final status for pipeline parent parameter #6164

Merged
merged 1 commit into from
May 5, 2022
Merged

fix(api): use final status for pipeline parent parameter #6164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion engine/api/workflow/process_parameters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,10 +190,10 @@ func getParentParameters(w *sdk.WorkflowRun, nodeRuns []*sdk.WorkflowNodeRun) ([
return nil, sdk.WithStack(fmt.Errorf("unable to find node %d in workflow", parentNodeRun.WorkflowNodeID))
}
nodeName = node.Name
prefix := "workflow." + nodeName + "."

parentParams := make([]sdk.Parameter, 0, len(parentNodeRun.BuildParameters))
for _, param := range parentNodeRun.BuildParameters {
prefix := "workflow." + nodeName + "."
if param.Name == "" || param.Name == "cds.semver" || param.Name == "cds.release.version" ||
strings.HasPrefix(param.Name, "cds.proj") ||
strings.HasPrefix(param.Name, "cds.version") || strings.HasPrefix(param.Name, "cds.run.number") ||
Expand Down Expand Up @@ -222,11 +222,22 @@ func getParentParameters(w *sdk.WorkflowRun, nodeRuns []*sdk.WorkflowNodeRun) ([

if param.Name == "payload" || strings.HasPrefix(param.Name, "cds.triggered") || strings.HasPrefix(param.Name, "cds.release") {
// keep p.Name as is
} else if param.Name == "cds.status" {
// do not use input status value for parent param
continue
} else if strings.HasPrefix(param.Name, "cds.") {
param.Name = strings.Replace(param.Name, "cds.", prefix, 1)
}
parentParams = append(parentParams, param)
}

// inject parent final status as parameter
parentParams = append(parentParams, sdk.Parameter{
Name: prefix + "status",
Type: sdk.StringParameter,
Value: parentNodeRun.Status,
})

params = append(params, parentParams...)
}
return params, nil
Expand Down