Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: project v2 handler #7256

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: project v2 handler #7256

wants to merge 2 commits into from

Conversation

sguiheux
Copy link
Collaborator

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@sguiheux sguiheux marked this pull request as ready for review December 18, 2024 09:59
yesnault
yesnault requested changes Dec 26, 2024
View reviewed changes
engine/api/v2_project.go
return sdk.WrapError(err, "cannot load project %s", key)
}

// TODO Delete
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need on v2 routes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That why there is a TODO. I don't know yet how it will be implement on UI side

engine/api/v2_project.go
return sdk.WrapError(errProj, "getProjectHandler (%s)", key)
}

// TODO REMOVE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesnault yesnault yesnault approved these changes

@fsamin fsamin Awaiting requested review from fsamin fsamin is a code owner

@richardlt richardlt Awaiting requested review from richardlt richardlt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sguiheux @yesnault