Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Public Cloud Load Balancer examples #36

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Add Public Cloud Load Balancer examples #36

wants to merge 14 commits into from

Conversation

antonin-a
Copy link

No description provided.

@scraly
Copy link
Collaborator

scraly commented Jan 22, 2024

Hi @antonin-a
For each of the example is it possible to add a README.md file that explain what is this example, for which case and how to use/deploy it?

Thank you! :)

scraly
scraly requested changes Jan 22, 2024
View reviewed changes
containers-orchestration/managed-kubernetes/use-public-cloud-load-balancer/basic_lb/readme.md Outdated Show resolved Hide resolved
...ublic-cloud-load-balancer/basic_lb_keepip/lb_keepip_reuse_or_already_existing_in_tenant.yaml Outdated Show resolved Hide resolved
...ublic-cloud-load-balancer/basic_lb_keepip/lb_keepip_reuse_or_already_existing_in_tenant.yaml Outdated Show resolved Hide resolved
...ged-kubernetes/use-public-cloud-load-balancer/private_lb/lb_private_with_openstack_port.yaml Outdated Show resolved Hide resolved
containers-orchestration/managed-kubernetes/use-public-cloud-load-balancer/readme.md Outdated Show resolved Hide resolved
containers-orchestration/managed-kubernetes/use-public-cloud-load-balancer/resize_lb/README.md Outdated Show resolved Hide resolved
containers-orchestration/managed-kubernetes/use-public-cloud-load-balancer/resize_lb/README.md Outdated Show resolved Hide resolved
containers-orchestration/managed-kubernetes/use-public-cloud-load-balancer/resize_lb/README.md Show resolved Hide resolved
containers-orchestration/managed-kubernetes/use-public-cloud-load-balancer/resize_lb/README.md Outdated Show resolved Hide resolved
containers-orchestration/managed-kubernetes/use-public-cloud-load-balancer/resize_lb/README.md Outdated Show resolved Hide resolved
antonin-a and others added 9 commits February 9, 2024 11:33
@antonin-a @scraly
Update containers-orchestration/managed-kubernetes/use-public-cloud-l…
9924b46 
…oad-balancer/basic_lb/readme.md

Co-authored-by: Aurelie Vache <[email protected]>
@antonin-a @scraly
Update containers-orchestration/managed-kubernetes/use-public-cloud-l…
0aec681 
…oad-balancer/readme.md

Co-authored-by: Aurelie Vache <[email protected]>
@antonin-a @scraly
Update containers-orchestration/managed-kubernetes/use-public-cloud-l…
bbadfef 
…oad-balancer/resize_lb/README.md

Co-authored-by: Aurelie Vache <[email protected]>
@antonin-a @scraly
Update containers-orchestration/managed-kubernetes/use-public-cloud-l…
4967979 
…oad-balancer/resize_lb/README.md

Co-authored-by: Aurelie Vache <[email protected]>
@antonin-a @scraly
Update containers-orchestration/managed-kubernetes/use-public-cloud-l…
7af40ec 
…oad-balancer/resize_lb/README.md

Co-authored-by: Aurelie Vache <[email protected]>
@antonin-a @scraly
Update containers-orchestration/managed-kubernetes/use-public-cloud-l…
882c864 
…oad-balancer/resize_lb/README.md

Co-authored-by: Aurelie Vache <[email protected]>
@antonin-a
Update readme.md
5b2a49b
@antonin-a
Update readme.md
8d3cbd8
@antonin-a
Update readme.md
7042ef9
@antonin-a
Copy link
Author

Hi @antonin-a For each of the example is it possible to add a README.md file that explain what is this example, for which case and how to use/deploy it?

Thank you! :)

Hello @scraly , that is idea but we would like to publish a first version quickly and then complete it during the Beta phase.

philippart-s
philippart-s requested changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@philippart-s philippart-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @antonin-a ,
Before merging this PR can you fix the changes request by @scraly and myself?

For the readme topics, can you add a readme file, even if it's small with just one line to introduce the use case?

You can add more content to these readme afterwards but they will exist (and maybe someone else will help us add more content to these readme).

Thanks :)

.DS_Store Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete the file

containers-orchestration/.DS_Store Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete the file

@antonin-a
Copy link
Author

Hi @antonin-a , Before merging this PR can you fix the changes request by @scraly and myself?

For the readme topics, can you add a readme file, even if it's small with just one line to introduce the use case?

You can add more content to these readme afterwards but they will exist (and maybe someone else will help us add more content to these readme).

Thanks :)

Ok, working on it :)

@scraly
Copy link
Collaborator

scraly commented Mar 26, 2024

Any updates? :)

@scraly
Copy link
Collaborator

scraly commented May 6, 2024

petit up :)

@antonin-a
Copy link
Author

Hello, still on it and almost finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippart-s philippart-s philippart-s requested changes

@scraly scraly scraly requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonin-a @scraly @philippart-s