Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tries to download disabled / unavailable songs #6

Closed
oviirup opened this issue May 13, 2021 · 2 comments
Closed

Tries to download disabled / unavailable songs #6

oviirup opened this issue May 13, 2021 · 2 comments
Assignees
Labels
bug Something isn't working easy fix should be fixed easily

Comments

@oviirup
Copy link
Owner

oviirup commented May 13, 2021

Some songs are disabled for some reason by the admin. The extension tries to download that also and throws an error...
Thanks to @jineshpatel30 to point that out...
should be easily fixed with following response from the server

{
  ...
  "rights": {
    "code": 1,
    "reason": "Unavailable",
    "cacheable": false,
    "delete_cached_object": true
  },
  "disabled": "true",
  "disabled_text": "Unavailable",
  "cache_state": "false",
  ...
}
@oviirup oviirup added bug Something isn't working easy fix should be fixed easily labels May 13, 2021
@oviirup oviirup added this to the Fix error of unavailable songs milestone May 13, 2021
@Jinestic
Copy link

Errors spotted regarding this. These errors doesn't affect running download, i.e. it just skips these files in current download but due to errors, Download button doesn't show up in other playlist till we clear reported errors in the extension.

image

@oviirup oviirup modified the milestones: Fix error of unavailable songs, Version 0.7 May 14, 2021
@oviirup oviirup mentioned this issue May 14, 2021
@oviirup oviirup self-assigned this May 14, 2021
@oviirup
Copy link
Owner Author

oviirup commented May 14, 2021

Errors spotted regarding this. These errors doesn't affect running download, i.e. it just skips these files in current download but due to errors, Download button doesn't show up in other playlist till we clear reported errors in the extension.

It is fixed in 572fa4d

oviirup added a commit that referenced this issue May 14, 2021
@oviirup oviirup closed this as completed May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working easy fix should be fixed easily
Projects
None yet
Development

No branches or pull requests

2 participants