Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused WP topic page code #3720

Merged
merged 11 commits into from
Jun 25, 2024
Merged

Remove unused WP topic page code #3720

merged 11 commits into from
Jun 25, 2024

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented Jun 18, 2024

No description provided.

@owidbot
Copy link
Contributor

owidbot commented Jun 18, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-remove-wp-topic-page-code

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-06-18 21:40:44 UTC
Execution time: 1.11 seconds

@marcelgerber marcelgerber self-requested a review June 19, 2024 09:15
@marcelgerber marcelgerber force-pushed the remove-wp-topic-page-code branch from b9fa8e8 to 86bd008 Compare June 19, 2024 09:16
@marcelgerber
Copy link
Member

I've now also removed the WP AllCharts component, and all the code needed for handling it.

I checked all current occurrences of runRelatedCharts(), and the only one with a non-empty array is /coronavirus, which is explicitly excluded from having an all-charts block because it has a country page.

Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see it!

baker/SiteBaker.tsx Outdated Show resolved Hide resolved
baker/SiteBaker.tsx Outdated Show resolved Hide resolved
baker/SiteBaker.tsx Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line export const KEY_INSIGHTS_CLASS_NAME = "wp-block-owid-key-insights" is now also unused

db/db.ts Outdated Show resolved Hide resolved
@ikesau ikesau force-pushed the remove-wp-topic-page-code branch from 86bd008 to 9382bc9 Compare June 20, 2024 18:39
@marcelgerber marcelgerber marked this pull request as ready for review June 21, 2024 10:42
@marcelgerber marcelgerber force-pushed the remove-wp-topic-page-code branch from 9d2a5df to e334756 Compare June 24, 2024 11:15
@ikesau ikesau merged commit 537dcbc into master Jun 25, 2024
8 checks passed
@ikesau ikesau deleted the remove-wp-topic-page-code branch June 25, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants