Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused env vars #4360

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Remove unused env vars #4360

merged 4 commits into from
Jan 10, 2025
+4 −10

Conversation

mlbrgl
Copy link
Member

@mlbrgl mlbrgl commented Dec 30, 2024 •
edited
Loading

⚠️ do not merge before https://github.com/owid/ops/pull/252 (this PR will continue to fail until the ops one is merged)

✨ This improves the parity with admin-env.secret, so setting up a new dev environment requires less guesswork.

Removed unused env vars from server settings:

  • GDOCS_IMAGES_BACKPORTING_TARGET_FOLDER
  • GDOCS_SHARED_DRIVE_ID

Move GDOCS_DONATE_FAQS_DOCUMENT_ID to admin-env.secret (see https://github.com/owid/ops/pull/252/commits/35319af185e317348223c2dc0cc68a57700d1b40)

@mlbrgl Graphite App
Copy link
Member Author

mlbrgl commented Dec 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mlbrgl mlbrgl changed the title feat(gdocs): remove unused images backporting folder setting refactor(gdocs): remove unused images backporting folder setting Dec 30, 2024
@mlbrgl mlbrgl marked this pull request as ready for review December 30, 2024 18:10
@mlbrgl mlbrgl requested a review from ikesau December 30, 2024 18:10
@owidbot
Copy link
Contributor

owidbot commented Dec 30, 2024 •
edited
Loading

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-env-var-cleanup

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-01-10 13:37:36 UTC
Execution time: 1.28 seconds

@mlbrgl mlbrgl changed the title refactor(gdocs): remove unused images backporting folder setting Remove unused env vars Dec 31, 2024
@mlbrgl mlbrgl mentioned this pull request Jan 2, 2025
Merged
@mlbrgl mlbrgl mentioned this pull request Jan 8, 2025
Merged
@mlbrgl
Copy link
Member Author

mlbrgl commented Jan 10, 2025

rebuild staging with updated ops

@mlbrgl mlbrgl closed this Jan 10, 2025
@mlbrgl mlbrgl reopened this Jan 10, 2025
@mlbrgl Graphite App
Copy link
Member Author

mlbrgl commented Jan 10, 2025 •
edited
Loading

Merge activity

  • Jan 10, 9:00 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 10, 9:01 AM EST: A user merged this pull request with Graphite.

@mlbrgl mlbrgl merged commit f2c69b4 into master Jan 10, 2025
22 checks passed
@mlbrgl mlbrgl deleted the env-var-cleanup branch January 10, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikesau ikesau ikesau approved these changes

Assignees

@mlbrgl mlbrgl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlbrgl @owidbot @ikesau