🐛 take table filter toggle into account for data download / TAS-796 #4433
+66
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-01-10 10:51:14 UTC |
sophiamersmann
force-pushed
the
fix-filtered-data-download
branch
from
525b08c to
a67c9c0
Compare
sophiamersmann
commented
Jan 10, 2025
| @@ -68,10 +68,12 @@ export async function fetchZipForGrapher( | |||
| } | |||
| function assembleCsv(grapher: Grapher, searchParams: URLSearchParams): string { | |||
| const useShortNames = searchParams.get("useColumnShortNames") === "true" | |||
| const fullTable = grapher.inputTable // TODO: should this be table? | |||
There was a problem hiding this comment.
Should this be table instead? inputTable includes all data, table is filtered by the time range set by the author (note that this is the author's time range, not the user's).
Not sure what's intended here, but the client side uses table, so regardless of what we choose, server and client should probably use the same table.
sophiamersmann
force-pushed
the
fix-filtered-data-download
branch
from
a67c9c0 to
7d33c7f
Compare
sophiamersmann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4432
If 'Show selection only' on the table tab is toggled, then 'Download displayed data' only downloads data for those entities that are displayed in the table.
If 'Show selection only' isn't toggled, then 'Download displayed data' downloads all data (since all data is displayed). Don't know if this could be confusing. I find it okay.
This PR makes non-trivial changes to the Grapher component. Let me know if you prefer to wait for your refactor before merging this PR.
👇🏻 See my comment about
grapher.inputTablevsgrapher.tablebelow