drop delete logic

owkin · Nov 30, 2023 · a441092 · a441092
1 parent f4723d1
commit a441092
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 9 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -27,10 +27,13 @@ class Package {
     constructor(name, version, extraFields) {
         this.name = name;
         this.version = version;
-        // omit name and version from extra fields to avoid overriding
-        extraFields === null || extraFields === void 0 ? true : delete extraFields.name;
-        extraFields === null || extraFields === void 0 ? true : delete extraFields.version;
-        Object.assign(this, extraFields);
+        if (extraFields) {
+            for (const [key, value] of Object.entries(extraFields)) {
+                if (key !== 'name' && key !== 'version') {
+                    Object.assign(this, { [key]: value });
+                }
+            }
+        }
     }
 }
 exports.Package = Package;

diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/dependencies.ts b/src/dependencies.ts
@@ -27,10 +27,13 @@ export class Package {
   ) {
     this.name = name
     this.version = version
-    // omit name and version from extra fields to avoid overriding
-    delete extraFields?.name
-    delete extraFields?.version
-    Object.assign(this, extraFields)
+    if (extraFields) {
+      for (const [key, value] of Object.entries(extraFields)) {
+        if (key !== 'name' && key !== 'version') {
+          Object.assign(this, {[key]: value})
+        }
+      }
+    }
   }
 }