fix: replace deprecated default download server url #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Robert Kaussow <[email protected]>
|
Can you please rebase your PR? |
|
You mean to get rid of all those merge commits in between? I thought you would squash them anyway. The branch itself was up-to-date with upstream, that's why there is only one file changed. |
|
Yeah, it's still cluttering the PR a bit and make reviewing a merged PR after months harder to understand if it contains commits that have nothing to do with the PR itself. I'm going to merge it as it is for now, next time please use a clean branch for each PR on your fork. |
xoxys
changed the title
ownclouders
pushed a commit
that referenced
this pull request
Jun 13, 2022
Author: Dennis Sieben <[email protected]> Date: Mon Jun 13 21:32:16 2022 +0200 fix: replace deprecated default download server url (#67)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some internal discussion it seems the URL has to be adjusted as version 10.10 is not available in the old default URL but in the new one contained in this PR.