[FEATURE REQUEST] Select correct user and navigate to the correct file when opening via deep link

[manuelplazaspalacio]

Related Issues

App: #4194

• Added changelog files for the fixed issues in folder changelog/unreleased. More info here

---

QA

• (1) Downloaded files in root folder of oC10 not displayed [FEATURE REQUEST] Select correct user and navigate to the correct file when opening via deep link  #4212 (comment) [FIXED]
• (2) Fille id collation [FEATURE REQUEST] Select correct user and navigate to the correct file when opening via deep link  #4212 (comment) [WONT FIX]
• (3) Lack of connection not correctly handled [FEATURE REQUEST] Select correct user and navigate to the correct file when opening via deep link  #4212 (comment)
• (4) mountpoint not supported [FEATURE REQUEST] Select correct user and navigate to the correct file when opening via deep link  #4212 (comment)

[jabarros]

LGTM

[jesmrec]

Starting QA...

[jesmrec]

(1) [FIXED]

Open files in root of oC10 does not work for me. Tested with two different servers, getting Unknown error or The user doesn't have access to the file

Files pointed are stored in the root folder of oC10 account (that means, already discovered) and they are already downloaded.

Screen_recording_20231127_124340.mp4

Pixel 2 Android 11
c3bb396b5

[jesmrec]

(2) [WONT FIX]

When there are some accounts in the device, the way to check which account is the pointed file in, is checking whether the file id exists in an account.

But, is posible that two accounts on the device have a file with the same id (likely in oC10 that is numerical) . In that case, link is not correctly solved.

Pixel 2 Android 11
c3bb396b5

[michaelstingl]

(2)

But, is posible that two accounts on the device have a file with the same id (likely in oC10 that is numerical) . In that case, link is not correctly solved.

Coordinate with iOS team, then maybe document behaviour.

[JuancaG05]

@jesmrec (1) should be fixed, (2) won't be fixed now, and it also works now for servers that include /index.php in their URL. We use now the meta endpoint (/remote.php/dav/meta/) for oC10 as well.

[jesmrec]

(3)

Behaviour against lack of connection is not correct:

• If file is discovered and not downloaded, opening the link should show the Details view, no matter if the file is previewable or not (same as clicking directly the file)
• If the file is downloaded, lack of connection does not have to avoid opening it.
• If a folder is discovered, it should show the content

Lack of connection should affect only if the item has not been discovered yet, or if it is not downloaded showing the Details view.

[jesmrec]

(4)

Current iteration is not working with links against shared items (mountpoint drives). Just against personal and project drives.

@michaelstingl is this OK ftm, or is also required for 4.2 (beta.1 or official)?

[michaelstingl]

@michaelstingl is this OK ftm, or is also required for 4.2 (beta.1 or official)?

Okay as "known limitation" for the beta1 I'd say 👍

[jesmrec]

(3) and (4) will be addressed in different issues, so this is approved with restrictions:

• Behaviour without connection is not totally correct
• Links over shared items are not handled