Skip to content

Commit

Permalink
Fix opening the browser
Browse files Browse the repository at this point in the history
Due to a bug opening in browser only worked when logs where active
  • Loading branch information
TheOneRing committed Jan 4, 2023
1 parent f1316bf commit 01fc810
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
5 changes: 5 additions & 0 deletions changelog/unreleased/10387
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Open in web if debug logs are turned off

Due to a bug opening the browser only worked if logging was enabled.

https://github.com/owncloud/client/pull/10387
3 changes: 2 additions & 1 deletion src/libsync/appprovider.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ bool AppProvider::open(const AccountPtr &account, const QString &localPath, cons
QObject::connect(job, &JsonJob::finishedSignal, [job, localPath] {
if (job->httpStatusCode() == 200) {
const auto url = QUrl(job->data().value(QStringLiteral("uri")).toString());
qCDebug(lcAppProvider) << "start browser" << url << QDesktopServices::openUrl(url);
const auto result = QDesktopServices::openUrl(url);
qCDebug(lcAppProvider) << "start browser" << url << result;
} else {
QMetaObject::invokeMethod(qApp, "slotShowGuiMessage", Qt::QueuedConnection,
Q_ARG(QString, QCoreApplication::translate("AppProvider", "Error")),
Expand Down

0 comments on commit 01fc810

Please sign in to comment.