Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt6: Use requestSend signal in httplogger #10313

Closed
TheOneRing opened this issue Nov 24, 2022 · 1 comment · Fixed by #10848
Closed

Qt6: Use requestSend signal in httplogger #10313

TheOneRing opened this issue Nov 24, 2022 · 1 comment · Fixed by #10848
Labels
p2-high Escalation, on top of current planning, release blocker Qt6
Milestone
Desktop 5.0

Comments

@TheOneRing
Copy link
Contributor

Qt6 provides a requestSend signal.
This signal allows us to actually print the final request and not the one we scheduled.
It will also improve the measured time.
@TheOneRing TheOneRing added the Qt6 label Nov 24, 2022
@TheOneRing TheOneRing added this to the 5.0 milestone Nov 24, 2022
@TheOneRing TheOneRing changed the title Use requestSend signal in httplogger Qt6: Use requestSend signal in httplogger Nov 24, 2022
@TheOneRing TheOneRing reopened this Apr 13, 2023
@michaelstingl michaelstingl added the p2-high Escalation, on top of current planning, release blocker label Apr 13, 2023
TheOneRing added a commit that referenced this issue May 17, 2023
@TheOneRing
Use QNetworkReply::requestSent to improve httplog
a7dadda 
Fixes: #10313
@TheOneRing TheOneRing mentioned this issue May 17, 2023
Merged
TheOneRing added a commit that referenced this issue May 25, 2023
@TheOneRing
Use QNetworkReply::requestSent to improve httplog
d889ce6 
Fixes: #10313
TheOneRing added a commit that referenced this issue May 26, 2023
@TheOneRing
Use QNetworkReply::requestSent to improve httplog
add5549 
Fixes: #10313
TheOneRing added a commit that referenced this issue May 30, 2023
@TheOneRing
Use QNetworkReply::requestSent to improve httplog
bdf6faf 
Fixes: #10313
@saw-jan
Copy link
Member

saw-jan commented Jun 8, 2023

Is there any way that we can check this improvement? Or move it to Done?
CC @TheOneRing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p2-high Escalation, on top of current planning, release blocker Qt6
Projects
None yet
Milestone
Desktop 5.0
Development

Successfully merging a pull request may close this issue.

Use QNetworkReply::requestSent to improve httplog owncloud/client
3 participants
@TheOneRing @michaelstingl @saw-jan