Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't add account when password cointains non ascii character (windows only) #10564

Closed
2 tasks done
gregoryR opened this issue Mar 3, 2023 · 2 comments · Fixed by #10565
Closed
2 tasks done

can't add account when password cointains non ascii character (windows only) #10564

gregoryR opened this issue Mar 3, 2023 · 2 comments · Fixed by #10565
Labels

Comments

@gregoryR
Copy link

gregoryR commented Mar 3, 2023

Pre-submission Checks

  • I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
  • I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the bug

When adding an account on windows, the authentication is refused when the password contains a non ascii character : à or é for example

On the same machine and the same account, adding an account succeeds when the password is entirely formed of ascii characters even with specials characters like & -...

Expected behavior

password with non ascii characters should be accepted in the client

Steps to reproduce the issue

  1. click on +
  2. enter the url of the server
  3. enter credentials, login and password
  4. credentials are refused

Error message in the is :

Login failed: username and/or password incorrect

Screenshots

No response

Logs

Here is what I find in the client logs for version ownCloud 3.2.0.10193 718af2 on Windows

23-03-03 14:27:31:427 [ info wizard.resolveurl ]:	QUrl("https://[REDACTED]") was redirected to QUrl("https://[REDACTED]/")
23-03-03 14:27:31:427 [ info wizard.resolveurl ]:	redirect accepted automatically
23-03-03 14:27:31:427 [ info sync.httplogger ]:	"101653df-ad25-4e6b-8338-2272c72143e6: Request: PROPFIND https://[REDACTED]/remote.php/webdav/ Header: { User-Agent: Mozilla/5.0 (Windows) mirall/3.2.0.10193 (ownCloud, windows-10.0.19045 ClientArchitecture: x86_64 OsArchitecture: x86_64), Accept: */*, Content-Type: text/xml; charset=utf-8, X-Request-ID: 101653df-ad25-4e6b-8338-2272c72143e6, Original-Request-ID: 101653df-ad25-4e6b-8338-2272c72143e6, Cookie: oc309f9eec79=m3kfueuqcgle7g1o4i7p81pkcc; oc_sessionPassphrase=Eq5R7ESd93gBdiJUGghz8k9uvA%2Fj7zr%2F7Mb6vl%2B7qcM%2BACYotFZ%2FHKTVGt7XcFOntXpbPDUUI2YutZKATzk4Np5yzp4B4C9WvQqLFumdyT6rcJzzfI8sBHkuNijDQbH9, } Data: []"
23-03-03 14:27:31:457 [ info sync.httplogger ]:	"101653df-ad25-4e6b-8338-2272c72143e6: Response: PROPFIND 401 (Error: L'hôte requiert une authentification,29ms) https://[REDACTED]/remote.php/webdav/ Header: { Date: Fri, 03 Mar 2023 13:27:31 GMT, Server: Microsoft-IIS/8.0, Strict-Transport-Security: max-age=15768000; preload, X-Content-Type-Options: nosniff, X-XSS-Protection: 0, X-Robots-Tag: none, X-Frame-Options: SAMEORIGIN, X-Download-Options: noopen, X-Permitted-Cross-Domain-Policies: none, Expires: Thu, 19 Nov 1981 08:52:00 GMT, Cache-Control: no-store, no-cache, must-revalidate, Pragma: no-cache, Content-Security-Policy: default-src 'none';, WWW-Authenticate: Basic realm=\"ownCloud\", charset=\"UTF-8\", Content-Length: 412, Content-Type: application/xml; charset=utf-8, Referrer-Policy: strict-origin-when-cross-origin, Set-Cookie: oc_sessionPassphrase=Eq5R7ESd93gBdiJUGghz8k9uvA%2Fj7zr%2F7Mb6vl%2B7qcM%2BACYotFZ%2FHKTVGt7XcFOntXpbPDUUI2YutZKATzk4Np5yzp4B4C9WvQqLFumdyT6rcJzzfI8sBHkuNijDQbH9; expires=Fri, 03-Mar-2023 13:47:31 GMT; Max-Age=1200; path=/; SameSite=Strict; HttpOnly; Secure, Keep-Alive: timeout=2, max=149, Connection: Keep-Alive, } Data: [<?xml version=\"1.0\" encoding=\"utf-8\"?>\n<d:error xmlns:d=\"DAV:\" xmlns:s=\"http://sabredav.org/ns\">\n  <s:exception>Sabre\\DAV\\Exception\\NotAuthenticated</s:exception>\n  <s:message>No 'Authorization: Basic' header found. Either the client didn't send one, or the server is misconfigured, No 'Authorization: Basic' header found. Either the client didn't send one, or the server is misconfigured</s:message>\n</d:error>\n]"
23-03-03 14:27:31:457 [ info sync.networkjob.determineauthtype2 ]:	Auth type for QUrl("https://[REDACTED]/remote.php/webdav/") is OCC::DetermineAuthTypeJob::AuthType::Basic
23-03-03 14:27:31:458 [ debug default ]	[ OCC::BasicLoginWidget::BasicLoginWidget ]:	true
23-03-03 14:27:31:458 [ debug default ]	[ OCC::BasicLoginWidget::BasicLoginWidget ]:	true
23-03-03 14:27:31:474 [ debug setupwizard.controller ]	[ OCC::Wizard::SetupWizardController::changeStateTo ]:	Current wizard state: OCC::Wizard::SetupWizardState::CredentialsState
...
23-03-03 14:28:27:662 [ debug setupwizard.controller ]	[ OCC::Wizard::SetupWizardController::{ctor}::::operator() ]:	next button clicked, current state OCC::Wizard::BasicCredentialsSetupWizardState(0x1ed60081dc0)
23-03-03 14:28:27:663 [ info sync.httplogger ]:	"0c7f3ca5-05e0-47d8-8504-8a4ddbe3db46: Request: PROPFIND https://[REDACTED]/remote.php/webdav/ Header: { Authorization: Basic [redacted], User-Agent: Mozilla/5.0 (Windows) mirall/3.2.0.10193 (ownCloud, windows-10.0.19045 ClientArchitecture: x86_64 OsArchitecture: x86_64), Accept: */*, Content-Type: text/xml; charset=utf-8, X-Request-ID: 0c7f3ca5-05e0-47d8-8504-8a4ddbe3db46, Original-Request-ID: 0c7f3ca5-05e0-47d8-8504-8a4ddbe3db46, Cookie: oc309f9eec79=m3kfueuqcgle7g1o4i7p81pkcc; oc_sessionPassphrase=Eq5R7ESd93gBdiJUGghz8k9uvA%2Fj7zr%2F7Mb6vl%2B7qcM%2BACYotFZ%2FHKTVGt7XcFOntXpbPDUUI2YutZKATzk4Np5yzp4B4C9WvQqLFumdyT6rcJzzfI8sBHkuNijDQbH9, } Data: []"
23-03-03 14:28:27:763 [ info sync.httplogger ]:	"0c7f3ca5-05e0-47d8-8504-8a4ddbe3db46: Response: PROPFIND 401 (Error: L'hôte requiert une authentification,99ms) https://[REDACTED]/remote.php/webdav/ Header: { Date: Fri, 03 Mar 2023 13:28:27 GMT, Server: Microsoft-IIS/8.0, Strict-Transport-Security: max-age=15768000; preload, X-Content-Type-Options: nosniff, X-XSS-Protection: 0, X-Robots-Tag: none, X-Frame-Options: SAMEORIGIN, X-Download-Options: noopen, X-Permitted-Cross-Domain-Policies: none, Expires: Thu, 19 Nov 1981 08:52:00 GMT, Cache-Control: no-store, no-cache, must-revalidate, Pragma: no-cache, Content-Security-Policy: default-src 'none';, WWW-Authenticate: Basic realm=\"ownCloud\", charset=\"UTF-8\", Content-Length: 270, Content-Type: application/xml; charset=utf-8, Referrer-Policy: strict-origin-when-cross-origin, Set-Cookie: oc_sessionPassphrase=Eq5R7ESd93gBdiJUGghz8k9uvA%2Fj7zr%2F7Mb6vl%2B7qcM%2BACYotFZ%2FHKTVGt7XcFOntXpbPDUUI2YutZKATzk4Np5yzp4B4C9WvQqLFumdyT6rcJzzfI8sBHkuNijDQbH9; expires=Fri, 03-Mar-2023 13:48:27 GMT; Max-Age=1200; path=/; SameSite=Strict; HttpOnly; Secure\noc309f9eec79=1mks2mesmuq0enijff17j9c9f0; path=/; SameSite=Strict; HttpOnly; Secure, Keep-Alive: timeout=2, max=150, Connection: Keep-Alive, } Data: [<?xml version=\"1.0\" encoding=\"utf-8\"?>\n<d:error xmlns:d=\"DAV:\" xmlns:s=\"http://sabredav.org/ns\">\n  <s:exception>Sabre\\DAV\\Exception\\NotAuthenticated</s:exception>\n  <s:message>Username or password was incorrect, Username or password was incorrect</s:message>\n</d:error>\n]"
23-03-03 14:28:27:766 [ debug default ]	[ OCC::BasicLoginWidget::BasicLoginWidget ]:	true
23-03-03 14:28:27:766 [ debug default ]	[ OCC::BasicLoginWidget::BasicLoginWidget ]:	true
23-03-03 14:28:27:778 [ debug setupwizard.controller ]	[ OCC::Wizard::SetupWizardController::changeStateTo ]:	Current wizard state: OCC::Wizard::SetupWizardState::CredentialsState

And in the server logs

Mar  3 14:28:27 vextracloud2 [REDACTED][13298]: [0c7f3ca5-05e0-47d8-8504-8a4ddbe3db46][[REDACTED]][--][core][PROPFIND][/remote.php/webdav/] Login failed: '[REDACTED]' (Remote IP: '[REDACTED]') 

Client version number

I can reproduce in two Windows versions of the client

ownCloud 3.0.0.9215- 457b08
Libraries Qt 5.15.5, OpenSSL 1.1.1q 5 Jul 2022
Using virtual files plugin: wincfapi
windows-10.0.19045

and

ownCloud 3.2.0.10193 718af2
Libraries Qt 5.15.5, OpenSSL 1.1.1q 5 Jul 2022
Using virtual files plugin: wincfapi
windows-10.0.19045

Desktop environment (Linux only)

No response

Client package version and origin (Linux only)

No response

Installation path (Windows only)

No response

Server information

"ownCloud version": "10.11.0.6",
"webserver version": "Apache\/2.4.38 (Debian)",
PHP Version": "7.3.31-1~deb10u2",

Authentication use the user_ldap app

"id": "user_ldap",
"name": "LDAP Integration"
"version": "0.16.1",

Additional context

On the Web UI passwords with non ascii characters are accepted for the same account

And I can't reproduce this issue on the Linux client

Debian 10

ownCloud 3.2.0.10193 718af2
Libraries Qt 5.15.2, OpenSSL 1.1.1n 15 Mar 2022
Using virtual files plugin: suffix
debian-4.19.0-23-amd64
TheOneRing added a commit that referenced this issue Mar 3, 2023
@fmoc
Copy link
Contributor

fmoc commented Mar 3, 2023

Confirmed, fix incoming.

TheOneRing added a commit that referenced this issue Mar 3, 2023
TheOneRing added a commit that referenced this issue Mar 3, 2023
@fmoc fmoc closed this as completed Mar 3, 2023
@HanaGemela
Copy link
Contributor

Tested with testpilotcloud-3.2.1.10329-rc3, Windows 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants