New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholder detection on Windows is wrong #11107

Closed

erikjv opened this issue Aug 9, 2023 · 1 comment · Fixed by #11105

Assignees

Labels

Windows

Collaborator

erikjv commented Aug 9, 2023

We check if the file size is 0 (zero) bytes, but a) non-placeholder files can be that size, and b) a partially hydrated placeholder can have a size.

erikjv added the Windows label

erikjv self-assigned this

erikjv added a commit that referenced this issue


          Add changelog entry for client-desktop-vfs-win PR 19

c20db2a

Fixes: #11107

TheOneRing closed this as completed in

8e920b4

TheOneRing linked a pull request

that will close this issue

Add changelog entry for client-desktop-vfs-win PR 19 #11105

Merged

Contributor

TheOneRing commented Aug 10, 2023

Testing is covered by unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment