Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wizard: Strip user info from url #11497

Closed
TheOneRing opened this issue Jan 30, 2024 · 1 comment · Fixed by #11509
Closed

Wizard: Strip user info from url #11497

TheOneRing opened this issue Jan 30, 2024 · 1 comment · Fixed by #11509
Assignees
@erikjv
Milestone
Desktop 6.0

Comments

@TheOneRing
Copy link
Contributor

TheOneRing commented Jan 30, 2024 •
edited
Loading

If a user enters a URL with username or password encoded, we should remove that information and not send it to the server (QUrl::RemoveUserInfo)
The user info should just be ignored, and the wizard will behave as if no information was provided.

Originally posted by @TheOneRing in #11045 (comment)
@TheOneRing TheOneRing mentioned this issue Jan 30, 2024
Closed
2 tasks
@TheOneRing TheOneRing added this to the Desktop 7.0 milestone Jan 30, 2024
@erikjv erikjv self-assigned this Jan 30, 2024
erikjv added a commit that referenced this issue Feb 6, 2024
@erikjv
Strip user info from URL in New Connection Wizard
763db8b 
Authentication is done through the web browser, so no user information
is needed for that URL.

Fixes: #11497
@erikjv erikjv mentioned this issue Feb 6, 2024
Merged
@TheOneRing TheOneRing modified the milestones: Desktop 7.0, Desktop 6.0 Feb 14, 2024
erikjv added a commit that referenced this issue Feb 16, 2024
@erikjv
Strip user info from URL in New Connection Wizard
a1f1a1f 
Authentication is done through the web browser, so no user information
is needed for that URL.

Fixes: #11497
TheOneRing pushed a commit that referenced this issue Feb 20, 2024
@erikjv @TheOneRing
Strip user info from URL in New Connection Wizard
b13668c 
Authentication is done through the web browser, so no user information
is needed for that URL.

Fixes: #11497
@saw-jan
Copy link
Member

saw-jan commented Mar 28, 2024

Tested on ownCloud 6.0.0.13582-daily20240327 [4258b6]

Screenshot from 2024-03-28 16-05-55 Screenshot from 2024-03-28 16-06-01 Screenshot from 2024-03-28 16-06-05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikjv erikjv

Labels
None yet
Projects
None yet
Milestone
Desktop 6.0
Development

Successfully merging a pull request may close this issue.

Strip user info from URL in New Connection Wizard owncloud/client
3 participants
@erikjv @TheOneRing @saw-jan