Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Since #11786 the label receives focus before the url #11800

Closed
TheOneRing opened this issue Aug 14, 2024 · 4 comments · Fixed by #11810
Closed

Since #11786 the label receives focus before the url #11800

TheOneRing opened this issue Aug 14, 2024 · 4 comments · Fixed by #11810
Assignees
@erikjv
Labels
Accessibility
Milestone
Desktop 6.0

Comments

@TheOneRing
Copy link
Contributor

  • The label receives focus
  • the focus is not visible
@TheOneRing TheOneRing modified the milestones: Accessibility, Desktop 6.0 Aug 14, 2024
@erikjv
Copy link
Collaborator

erikjv commented Aug 16, 2024

Yes, and on the next tab, the label is focused. It is handled inside the QLabel in a weird way: if you back-tab into the label, the link is not selected, and you then have to tab (NOT back-tab) to select it.

@TheOneRing
Copy link
Contributor Author

We could use two labels with a buddy?
One with just the url and we directly handle the keyboard interaction?

@erikjv
Copy link
Collaborator

erikjv commented Aug 19, 2024

We decided to remove the URL completely, and only show the connection status. We also added a "Open in browser" entry in the "Manage Account" button.

@erikjv erikjv linked a pull request Aug 19, 2024 that will close this issue
[a11y] Move server URL from status label to Account button #11810
Merged
erikjv added a commit that referenced this issue Aug 19, 2024
@erikjv
[a11y] Move server URL from status label to Account button
feaf129 
The URL in the status label of the account settings page was not
always accessible by keyboard. The label will now only show the
connection status, and the "Manage Account" button has a new entry
for "Open in Web Browser".

Fixes: #11800
Fixes: #11772
erikjv added a commit that referenced this issue Aug 28, 2024
@erikjv
[a11y] Move server URL from status label to Account button
4cbde2f 
The URL in the status label of the account settings page was not
always accessible by keyboard. The label will now only show the
connection status, and the "Manage Account" button has a new entry
for "Open in Web Browser".

Fixes: #11800
Fixes: #11772
erikjv added a commit that referenced this issue Aug 28, 2024
@erikjv
[a11y] Move server URL from status label to Account button
5ca4ebc 
The URL in the status label of the account settings page was not
always accessible by keyboard. The label will now only show the
connection status, and the "Manage Account" button has a new entry
for "Open in Web Browser".

Fixes: #11800
Fixes: #11772
erikjv added a commit that referenced this issue Aug 28, 2024
@erikjv
[a11y] Move server URL from status label to Account button
6713cb0 
The URL in the status label of the account settings page was not
always accessible by keyboard. The label will now only show the
connection status, and the "Manage Account" button has a new entry
for "Open in Web Browser".

Fixes: #11800
Fixes: #11772
erikjv added a commit that referenced this issue Aug 28, 2024
@erikjv
[a11y] Move server URL from status label to Account button
169e88f 
The URL in the status label of the account settings page was not
always accessible by keyboard. The label will now only show the
connection status, and the "Manage Account" button has a new entry
for "Open in Web Browser".

Fixes: #11800
Fixes: #11772
erikjv added a commit that referenced this issue Aug 29, 2024
@erikjv
[a11y] Move server URL from status label to Account button
64d9f12 
The URL in the status label of the account settings page was not
always accessible by keyboard. The label will now only show the
connection status, and the "Manage Account" button has a new entry
for "Open in Web Browser".

Fixes: #11800
Fixes: #11772
@saw-jan
Copy link
Member

saw-jan commented Sep 18, 2024

Tested on ownCloud 6.0.0.14688-daily20240918 [967f29]

Screenshot from 2024-09-18 18-14-24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikjv erikjv

Labels
Accessibility
Projects
None yet
Milestone
Desktop 6.0
Development

Successfully merging a pull request may close this issue.

[a11y] Move server URL from status label to Account button owncloud/client
3 participants
@erikjv @TheOneRing @saw-jan