Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors appear briefly and then are gone #5516

Closed
dbolton opened this issue Feb 5, 2017 · 10 comments
Closed

Errors appear briefly and then are gone #5516

dbolton opened this issue Feb 5, 2017 · 10 comments
Assignees
@ckamm
Labels
Design & UX ReadyToTest QA, please validate the fix/enhancement
Milestone
2.4.0

Comments

@dbolton
Copy link

dbolton commented Feb 5, 2017 •
edited by SamuAlfageme
Loading

Expected behaviour

If there is an error that needs user attention, then the user should get a chance to read the error at their own pace (or copy the error to the clipboard if needed)

Actual behaviour

The error message appears briefly as a Windows notification, but the notification/error message disappears before I get a chance to find the file location, or if I've stepped away from the computer when the sync happens, I never see the message. If there are multiple errors, the windows notification says the first error and then says something like "and 2 more errors" without details.

If I open the error log with F12 it only shows logs starting from the moment I open the log window, not the errors in the last 10 minutes or so.

Examples of these errors include:

  • Conflicting files (edited by two users at once)
  • File name conflicts (sometimes happens if I rename a file and only change a letter from upper to lowercase)

Client configuration

Client version: Version 2.2.4 (build 6408).

Operating system: Windows 10

OS language: US English

Qt version used by client package (Linux only, see also Settings dialog):

Client package (From ownCloud or distro) (Linux only):

Installation path of client:
@SamuAlfageme
Copy link
Contributor

@dbolton but you would still have info on the non-synced errors on the Activity > Not Synced tab, these include both error scenarios you pointed out, they also show in the account tab, right next to the folder sync connection that presents problems.

True that the windows notifications could be linked to the first view or be persistent (not be closed automatically, until the user does). What's your opinion on this?

Thanks for reporting! 😉

@dbolton
Copy link
Author

dbolton commented Feb 7, 2017 •
edited
Loading

The Activity > Not Synced tab shows a list of ignored files (like Microsoft Word hidden temporary files), but it does not list file conflicts or file name conflicts. (I just created a file conflict to double check that it does not appear).

It would make sense for the errors to be listed in the Activity section. (That is where I first looked for them).

@hodyroff
Copy link

hodyroff commented Feb 8, 2017

Would not a 4th tab for errors make most sense? If I like to check for conflict files I would not want to go through all the ignored once and not go through all my activities, rather have them in one view: "conflict and errors" maybe? Lets collect/discuss ideas.

@dbolton
Copy link
Author

dbolton commented Feb 8, 2017

The ignore files list isn't very long on my computer so I'm fine with them there or in a separate fourth tab. My main concern is that the errors are listed for longer than a moment so that the are available for reference when troubleshooting.

@pmaier1
Copy link

pmaier1 commented Mar 10, 2017

So a 4th tab for errors definitely makes sense, some ideas:

  • errors should stay permanently in a list until they are resolved
  • would be nice to also provide some kind of error handling (e.g. ignore the file or similar)
  • Error notification should pop-up once and need to be confirmed (not with every 'sync run' again and again)
  • 'Account view' should then just say something like 'There were errors during sync. See error tab'
  • Need to take care about overlaps between 'Not Synced' and 'Errors'
    a) Merge
    b) 'Not Synced' -> ignored files, 'Errors' -> errors and conflicts
    -> probably b)

Real-world example that shows the need for error handling:

client_errors

In this case I can only look for the files one-by-one and delete/reupload to make the errors disappear. Every 'sync run' shows the error notification again. Would be nice to be able to just dismiss/ignore those erroneous files, still see them in the error list in 'Activity' but have the client working smoothly.

Opinions/ideas? @guruz @ogoffart

@guruz guruz added this to the 2.4.0 milestone Mar 16, 2017
@michaelstingl
Copy link
Contributor

More improvements:

  • Files/folders excludes/blacklisted because of errors should be have error icon (not always consistent in 2.3.1, see screenshot)
  • Column label "Action" is misleading (see screenshot)
  • Add information to differentiate if the error is Client > Server or Server > Client (additional column or different icons? client_state-error-128_png_at_master_ _owncloud_client)

ie11_-_win8_1

@guruz guruz mentioned this issue May 9, 2017
Closed
ckamm added a commit that referenced this issue Jun 27, 2017
@ckamm
Add a more functional error view #5516
95fd4b0 
* Allow filtering of ignores and warnings to see only important bits.
* Navigate from the folder view to the error view by clicking on the
  error list with the red background.
* Move the error list into its own ui file to allow easier extension.
* Fix issue around tab id handling in ActivitySettings.
* Rename "Action" column to "Issue".

Not done:
* Protocol and Issue view probably want to share the same underlying
  model.
* Blacklisting of errors currently moves them into the 'ignored file'
  category; that should change because then they don't appear as errors
  and are easily filtered away.
* How should non-file errors be displayed? (e.g. "not enough disk space
  to start the sync!")
@ckamm
Copy link
Contributor

ckamm commented Jun 27, 2017

@michaelstingl @pmaier1 @guruz An small incremental PR for better error display: #5861

ckamm added a commit that referenced this issue Jun 27, 2017
@ckamm
Blacklist: Don't let errors become warnings #5516
7b59eeb 
Before, blacklisted errors were set to FileIgnored status and hence
displayed as warnings. Now, they have their own BlacklistedError
category which allows them to appear as errors in the issues list and in
the shell integration icons.
@ckamm
Copy link
Contributor

ckamm commented Jun 27, 2017

This one is about blacklisted errors looking like warnings: #5865

guruz pushed a commit that referenced this issue Jul 4, 2017
@ckamm @guruz
Blacklist: Don't let errors become warnings #5516
b1aaf05 
Before, blacklisted errors were set to FileIgnored status and hence
displayed as warnings. Now, they have their own BlacklistedError
category which allows them to appear as errors in the issues list and in
the shell integration icons.
ckamm added a commit that referenced this issue Jul 4, 2017
@ckamm
Add a more functional error view #5516 (#5861)
ce8341c 
* Add a more functional error view #5516

* Allow filtering of ignores and warnings to see only important bits.
* Navigate from the folder view to the error view by clicking on the
  error list with the red background.
* Move the error list into its own ui file to allow easier extension.
* Fix issue around tab id handling in ActivitySettings.
* Rename "Action" column to "Issue".
* Change mouse cursor to hand over button and new error list area

Several OSX fixes provided by guruz.
@ckamm
Copy link
Contributor

ckamm commented Sep 12, 2017

I think the core issue of "errors appear briefly and are then gone" is fixed with the above PRs.

@ckamm ckamm added the ReadyToTest QA, please validate the fix/enhancement label Sep 12, 2017
@SamuAlfageme
Copy link
Contributor

Indeed - 2.4 comes with @ckamm's great new error listing view: #5861

@dbolton you can try out the 2.4.0 alpha from https://owncloud.org/changelog/desktop/ 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckamm ckamm

Labels
Design & UX ReadyToTest QA, please validate the fix/enhancement
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
7 participants
@michaelstingl @dbolton @ckamm @guruz @hodyroff @SamuAlfageme @pmaier1