Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow context menu to open the local Folder/subfolder in selective sync list in main window #5596

Closed
guruz opened this issue Mar 10, 2017 · 5 comments
Closed

Allow context menu to open the local Folder/subfolder in selective sync list in main window #5596

guruz opened this issue Mar 10, 2017 · 5 comments
Assignees
@guruz @SamuAlfageme
Labels
Design & UX ReadyToTest QA, please validate the fix/enhancement
Milestone
2.4.0

Comments

@guruz
Copy link
Contributor

guruz commented Mar 10, 2017

No description provided.

@guruz guruz added this to the 2.4.0 milestone Mar 10, 2017
@ckamm
Copy link
Contributor

ckamm commented Mar 22, 2017 •
edited
Loading

@guruz Do you mean for the sync folder or for the individual selective-sync folders?

It seems we'll have to manually disambiguate single and double clicks for that, as well as prohibit normal QTreeView processing of mouse events (otherwise double clicks would also trigger a collapse/expand)

@guruz
Copy link
Contributor Author

guruz commented Mar 22, 2017

I meant individual folders.

@guruz
Copy link
Contributor Author

guruz commented Apr 12, 2017

Apparantly double click detection is tricky for Qt/legacy reasons, let's have it in a right-mouse button menu.

@guruz guruz changed the title Allow double click to open the local Folder in selective sync list in main window Allow double click or context menu to open the local Folder in selective sync list in main window Apr 12, 2017
@guruz guruz self-assigned this Apr 26, 2017
guruz added a commit that referenced this issue Apr 26, 2017
@guruz
Selective Sync: Open sub folder context menu #5596
87a6787
@guruz guruz added the ReadyToTest QA, please validate the fix/enhancement label Apr 26, 2017
guruz added a commit that referenced this issue May 3, 2017
@guruz
Selective Sync: Open sub folder context menu #5596
1da5d39
guruz added a commit that referenced this issue May 8, 2017
@guruz
Selective Sync: Open sub folder context menu #5596
fbe812b
@guruz
Copy link
Contributor Author

guruz commented May 8, 2017

Needs a quick test on Windows

@SamuAlfageme SamuAlfageme changed the title Allow double click or context menu to open the local Folder in selective sync list in main window Allow context menu to open the local Folder/subfolder in selective sync list in main window May 8, 2017
@SamuAlfageme
Copy link
Contributor

SamuAlfageme commented May 8, 2017 •
edited
Loading

Lookin' neat 😎

opensubfolder

  • Enabled for all downloaded folders (partially or not)
  • Disabled for the rest (not synced or currently-syncing* folders)

(*) Folders that are selected in the list but not yet downloaded could be identified somehow to avoid confusion:

@guruz guruz closed this as completed May 11, 2017
ogoffart added a commit that referenced this issue Nov 20, 2017
@ogoffart
AccountSettings: Use the proper position to show the menu over sub-fo…
0ccb689 
…lder

The menu can be open with the keyboard shortcut.

(Fixup for the fix of #5596)

Also use popup instead of exec to show the menu: it's safer as it does
not re-enter the event loop.
@ogoffart ogoffart mentioned this issue Nov 20, 2017
Merged
guruz pushed a commit that referenced this issue Nov 20, 2017
@ogoffart @guruz
AccountSettings: Use the proper position to show the menu over sub-fo…
e7a91a1 
…lder

The menu can be open with the keyboard shortcut.

(Fixup for the fix of #5596)

Also use popup instead of exec to show the menu: it's safer as it does
not re-enter the event loop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guruz guruz

@SamuAlfageme SamuAlfageme

Labels
Design & UX ReadyToTest QA, please validate the fix/enhancement
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
3 participants
@ckamm @guruz @SamuAlfageme