Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the external storages/big folders notice on account log-out #5809

Closed
SamuAlfageme opened this issue May 31, 2017 · 5 comments
Closed
Assignees
Labels
Design & UX Enhancement ReadyToTest QA, please validate the fix/enhancement
Milestone

Comments

@SamuAlfageme
Copy link
Contributor

Steps to reproduce

  1. Add a new external storage/folder exceeding the size limit set on the client
  2. Get notified in the account tab
  3. Don't select any option and log-out

Expected behavior

The options should be gone after log-out, the same way the selective sync list is.

@ckamm ckamm self-assigned this Jun 8, 2017
ckamm added a commit that referenced this issue Jun 8, 2017
The selective sync selections get reset in this case, while the
big folder warnings will pop up again on reconnection.
@ckamm
Copy link
Contributor

ckamm commented Jun 8, 2017

PR #5826

ckamm added a commit that referenced this issue Nov 21, 2017
The choices or big folder warnings will pop up again on reconnection.
@SamuAlfageme SamuAlfageme added this to the 2.5.0 milestone Nov 30, 2017
@SamuAlfageme SamuAlfageme added the ReadyToTest QA, please validate the fix/enhancement label Nov 30, 2017
ckamm added a commit that referenced this issue Dec 6, 2017
The choices or big folder warnings will pop up again on reconnection.
@SamuAlfageme
Copy link
Contributor Author

SamuAlfageme commented Jun 6, 2018

Still reproduces in Version 2.5.0alpha1 (build 9885) - my concerns from the comments on #5826 are still valid - e.g.

  1. Wait till the buttons appear
  2. Log out / disable the network on the OS
  3. Click on Synchronize all
  4. Log in / re-enable the connection on the host
  5. Client lost the selection

I'm still voting for the "if we don't display the selective sync list at all, do not display these buttons until connection is established back either" (#5826 (comment))

@SamuAlfageme SamuAlfageme removed the ReadyToTest QA, please validate the fix/enhancement label Jun 6, 2018
@ckamm
Copy link
Contributor

ckamm commented Jun 11, 2018

@SamuAlfageme My change only covered the case of edits to the selective sync list, not the "big folder" edit state :/

ckamm added a commit that referenced this issue Jun 11, 2018
The previous patch did forget about the big-folder-ui which should
also be hidden on disconnect.
ckamm added a commit that referenced this issue Jun 13, 2018
The previous patch did forget about the big-folder-ui which should
also be hidden on disconnect.
@ckamm ckamm added ReadyToTest QA, please validate the fix/enhancement and removed PR available labels Jun 13, 2018
@SamuAlfageme
Copy link
Contributor Author

Now, this is great stuff:

hide_external

Closing here! 🤘

@ckamm
Copy link
Contributor

ckamm commented Jun 19, 2018

Finally! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design & UX Enhancement ReadyToTest QA, please validate the fix/enhancement
Projects
None yet
Development

No branches or pull requests

2 participants