Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklisted items don't prevent parent directory etags from updating #6411

Closed
ckamm opened this issue Mar 27, 2018 · 3 comments
Closed

Blacklisted items don't prevent parent directory etags from updating #6411

ckamm opened this issue Mar 27, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@ckamm
Copy link
Contributor

ckamm commented Mar 27, 2018

Currently if an item is blacklisted it will not be reattempted. Instead it's set to Ignored and BlacklistedError. The intention is that we want to show the sync as successful and silently reattempt the file after some time. (the value of the whole feature is debatable)

The problem with this approach becomes clear in a specific scenario: Say the file A/foo.txt can't be downloaded and gets blacklisted after the first sync. On the second sync it doesn't get attempted and the sync as well as PropagateDirectory for A is successful, updating the etag of A. When the blacklist entry expires the client will know longer be aware that it needs to rediscover A and do something inside it.

@ckamm ckamm added the type:bug label Mar 27, 2018
@ckamm ckamm added this to the 2.4.2-maybe milestone Mar 27, 2018
@ckamm ckamm self-assigned this Mar 27, 2018
@ckamm
Copy link
Contributor Author

ckamm commented Mar 27, 2018

PR #6412

@ckamm
Copy link
Contributor Author

ckamm commented Mar 28, 2018

Keeping this open because I still want to add blacklisting tests - we've had none of them for too long.

ckamm added a commit that referenced this issue Mar 28, 2018
ckamm added a commit that referenced this issue Mar 28, 2018
ckamm added a commit that referenced this issue Mar 28, 2018
@ckamm ckamm closed this as completed Mar 28, 2018
@guruz
Copy link
Contributor

guruz commented Mar 28, 2018

This bug must exist since ages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants