-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blacklisted items don't prevent parent directory etags from updating #6411
Comments
PR #6412 |
ckamm
added a commit
that referenced
this issue
Mar 28, 2018
Keeping this open because I still want to add blacklisting tests - we've had none of them for too long. |
This bug must exist since ages? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently if an item is blacklisted it will not be reattempted. Instead it's set to
Ignored
andBlacklistedError
. The intention is that we want to show the sync as successful and silently reattempt the file after some time. (the value of the whole feature is debatable)The problem with this approach becomes clear in a specific scenario: Say the file
A/foo.txt
can't be downloaded and gets blacklisted after the first sync. On the second sync it doesn't get attempted and the sync as well asPropagateDirectory
forA
is successful, updating the etag ofA
. When the blacklist entry expires the client will know longer be aware that it needs to rediscoverA
and do something inside it.The text was updated successfully, but these errors were encountered: