Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selective sync "Apply" stuck if another sync folder has error (missing) #6675

Closed
moscicki opened this issue Jul 27, 2018 · 6 comments
Closed
Assignees
Labels
ReadyToTest QA, please validate the fix/enhancement
Milestone

Comments

@moscicki
Copy link
Contributor

MacOSX, client 2.4.1.

I have several sync folders. One of them is "broken" because it is missing completely (let's call it folder X).

image

However, another folder is OK (just some unresolved conflicts):
image

When I try to use selective sync on my OK folder I am not able to because "Apply" button seems to be stuck:

image

Whenever I click "Apply" I see these error messages (related to the "broken" folder X).
So there is some negative interaction for Selective Sync between the two under the hood:

07-27 16:47:34:198 [ warning sync.database.sql ]:	Error: "unable to open database file" for "/.../X/._sync_b2f43b5ea209.db"
07-27 16:47:34:198 [ warning sync.database.sql ]:	CANTOPEN extended errcode:  14
07-27 16:47:34:199 [ warning sync.database.sql ]:	CANTOPEN system errno:  2
07-27 16:47:34:199 [ warning sync.database ]:	Error opening the db:  "unable to open database file"
07-27 16:47:34:199 [ warning gui.folder.model ]:	Could not read selective sync list from db.
@ogoffart ogoffart self-assigned this Aug 1, 2018
ogoffart added a commit that referenced this issue Aug 1, 2018
@guruz guruz added this to the 2.5.0 milestone Aug 9, 2018
ogoffart added a commit that referenced this issue Aug 15, 2018
@guruz guruz added the ReadyToTest QA, please validate the fix/enhancement label Aug 17, 2018
@guruz
Copy link
Contributor

guruz commented Aug 17, 2018

@moscicki You can test this in a recent macOS 2.5.0 nightly.
E.g. https://download.owncloud.com/desktop/daily/ownCloud-qt5.10.1-2.5.0.10395-daily20180817.pkg

@jnweiger
Copy link
Contributor

jnweiger commented Nov 6, 2018

testing macos 10.14 Mojave

ownCloud-2.5.1.10814rc2.pkg

connect one account to demo.owncloud.com -> sync folder ownCloud
connect another account to demo.owncloud.org -> sync folder ownCloud2

use a shell to rm -rf ~/ownCloud2

force sync on the second account, the red error message unable to find local sync folder appears as expected.

  • click open the folder tree on the other account,
  • deselect e.g. the Documents folder.
  • Click Apply.
    -> The subfolder Documents gets removed. -> OK

The bug seems to be fixed.
However, after a few minutes the client crashes.
image

@guruz @ogoffart can we check if the crash is related?

@guruz
Copy link
Contributor

guruz commented Nov 6, 2018

@jnweiger will do tomorrow morning when crash log is parsed.

@ogoffart
Copy link
Contributor

ogoffart commented Nov 7, 2018

sentry report: https://sentry.io/owncloud/desktop-win-and-mac/issues/649245901/

  Module "QtCore", in QObject::property
  Module "QtNetwork", in QHttp2ProtocolHandler::qt_static_metacall
  Module "QtCore", in QObject::event
  Module "QtWidgets", in QApplicationPrivate::notify_helper
  Module "QtWidgets", in QApplication::notify
  Module "QtCore", in QCoreApplication::notifyInternal2
  Module "QtCore", in QCoreApplicationPrivate::sendPostedEvents
  Module "QtCore", in QEventDispatcherUNIX::processEvents
  Module "QtCore", in QEventLoop::exec
  Module "QtCore", in QThread::exec

The crash is unrelated to the original bug report. Could be a Qt bug.

Edit: This is https://bugreports.qt.io/browse/QTBUG-66913 , should be Fixed in Qt 5.11

@guruz
Copy link
Contributor

guruz commented Nov 7, 2018

@ogoffart Why is this issue marked as resolved in sentry? https://sentry.io/owncloud/desktop-win-and-mac/issues/649245901/

EDIT: I unresolved it

@guruz
Copy link
Contributor

guruz commented Nov 7, 2018

@jnweiger FYI see @ogoffart 's edit. It's a Qt bug that is fixed in later versions. (because you asked about this issue in the call)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReadyToTest QA, please validate the fix/enhancement
Projects
None yet
Development

No branches or pull requests

4 participants