Align testpilotcloud themeing with original ownCloud (except for name and artwork)

[jnweiger]

openSUSE Leap 42.2 and Fedora 28, testpilotcloud-client-2.5.0~beta1

When entering demo.owncloud.org, demo, demo in the firstrun wizard, The connect page opens.
and the user can choose several sync options.

Ontop of the connection page, the 'choose what to sync' popup immediately appears, with everything deselected. This popup should only appear, If I click 'Choose what to sync' and it should start with everything selected.

When dragging the popup a bit downwards, one can see that the radio button is at 'Synchronize everything' -- as seen in the screenshot above.

[ogoffart]

Note: testpilot has different theme options. One of them is that Theme::wizardSelectiveSyncDefaultNothing is set to true:

   /**
     * When true, the setup wizard will show the selective sync dialog by default and default
     * to nothing selected
     */
    virtual bool wizardSelectiveSyncDefaultNothing() const;

So it is expected to show this dialog. Maybe the problem is that the "synchronize everything from the server" is selected. This is because we choose the right checkbox when we close that dialog. So maybe i can fix it so the right radio button is selected.

[ogoffart]

#6686 will make sure that the "Choose what to sync" radio button is selected in that case.

[jnweiger]

Hmm, thanks for the explanation and the fix for the button logic.
But then, the fault is in the testpilot theme: It is meant for testing, so that users can explore a new client version before they upgrade their produciton client.
Its behaviour must not intentionally differ.

[ogoffart]

I think this was changed so this particular option could be tested, but was never reverted back.

In general, some branding options are different in the test client so they can be tested.
But that's true that it does not make so much sense as people have been complaining about that already that the behavior is different. (This option, and some other)
So we probably should remove most of the differences.

I don't have access to the source code of the test client, so i can't fix it.

[ogoffart]

@jnweiger , I consider that the "wrong checkbox" state is fixed.
If you want to make the theming of the testpilot client the same, you need to do it yourself for i don't have access to it.

[jnweiger]

tested on a fresh Ubuntu 18.04

rm -rf ~/.config/ownCloud\ Testpilot\ Edition
rm -rf ~/testpilotcloud
testpilotcloudcmd -v
testpilotcloud version 2.5.1daily20181031 (build 10426)

The connection wizardnow starts normally. (*) Synchronize everything is preselected. -> OK
When clicking on ( ) [Choose what to sync] the dialog opens with all elements selected. -> OK
This is consistent with the normal owncloud client -> OK

PASS