Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selective sync menu not opened by default #7336

Closed
HanaGemela opened this issue Jul 23, 2019 · 7 comments
Closed

Selective sync menu not opened by default #7336

HanaGemela opened this issue Jul 23, 2019 · 7 comments
Assignees
@TheOneRing
Labels
Design & UX p2-high Escalation, on top of current planning, release blocker ReadyToTest QA, please validate the fix/enhancement type:bug
Milestone
2.6.0

Comments

@HanaGemela
Copy link
Contributor

Another issue on icons #7321

Client: 2.6.0alpha2 (build 12128)
macOS: 10.14.5
Server: 10.2.1. (stable)

Steps to recreate:

  1. Add a new account
  2. Check the account tab

Actual result: The arrow points down which means that the menu is expanded and the list is empty - there are no folders in the root directory

image

User has to click on the arrow twice to open the list
This hides not only the selective sync list but also the warning message about what should be synced

image

Expected result: The list is expanded and all warning messages are shown by default once the account has been added so that the user knows that some actions are required and it is obvious why the files have not been synced yet
@HanaGemela HanaGemela added type:bug p3-medium Normal priority labels Jul 23, 2019
@HanaGemela HanaGemela added this to the 2.6.1 milestone Jul 23, 2019
@ckamm
Copy link
Contributor

ckamm commented Jul 26, 2019 •
edited
Loading

indeed. Does not happen with folder wizard, only if the folder is created as part of the account setup. It does not matter whether there are "big" folders in the folder. Probably due to the auto-expand that happens when switching to an account page with a single sync folder.

@ckamm ckamm self-assigned this Jul 26, 2019
ckamm added a commit that referenced this issue Jul 26, 2019
@ckamm
AccountSettings: Fetch subitems after wiping them
d7d6974 
That helps avoid empty lists after account creation #7336
@ckamm ckamm mentioned this issue Jul 26, 2019
Merged
@HanaGemela HanaGemela modified the milestones: 2.6.1, 2.6.0 Jul 29, 2019
@ckamm ckamm modified the milestones: 2.6.0, 2.6.1 Aug 1, 2019
@ckamm
Copy link
Contributor

ckamm commented Aug 1, 2019

Let's leave this for 2.6.1 to move ahead with 2.6.0 now.

@ckamm ckamm modified the milestones: 2.6.1, 2.6.0 Aug 1, 2019
ckamm added a commit that referenced this issue Aug 1, 2019
@ckamm
AccountSettings: Fetch subitems after wiping them
97ce20a 
That helps avoid empty lists after account creation #7336
@ckamm ckamm added ReadyToTest QA, please validate the fix/enhancement and removed PR available labels Aug 1, 2019
@HanaGemela
Copy link
Contributor Author

Works as expected on macOS 10.14.6, client 2.6.0beta1 (build 12241)

@HanaGemela
Copy link
Contributor Author

Broken again in 2.6.1sprint1 (build 12882), macOS 10.15.1
P2 as it is a regression

@HanaGemela HanaGemela reopened this Dec 18, 2019
@HanaGemela HanaGemela added p2-high Escalation, on top of current planning, release blocker and removed p3-medium Normal priority labels Dec 18, 2019
@michaelstingl michaelstingl assigned TheOneRing and unassigned ckamm Feb 3, 2020
@TheOneRing
Copy link
Contributor

@HanaGemela can't repoduce

@HanaGemela
Copy link
Contributor Author

@TheOneRing Still broken in 2.6.1 (build 13096), macOS. Steps to reproduce are correct

Screenshot 2020-02-04 at 09 28 03

TheOneRing added a commit to TheOneRing/client that referenced this issue Feb 4, 2020
@TheOneRing
Fix expansion of tree view on newly added accounts
67d4f09 
The change is based on 97ce20a

I removed a few lines of code there which are already part of fetchMore()

Fixes: owncloud#7336
TheOneRing added a commit to TheOneRing/client that referenced this issue Feb 4, 2020
@TheOneRing
Fix expansion of tree view on newly added accounts
58d54d6 
The change is based on 97ce20a

I removed a few lines of code there which are already part of fetchMore()

Fixes: owncloud#7336
TheOneRing added a commit to TheOneRing/client that referenced this issue Feb 11, 2020
@TheOneRing
Fix expansion of tree view on newly added accounts
1415297 
The change is based on 97ce20a

I removed a few lines of code there which are already part of fetchMore()

Fixes: owncloud#7336
TheOneRing added a commit to TheOneRing/client that referenced this issue Feb 11, 2020
@TheOneRing
Fix expansion of tree view on newly added accounts
f2dbe37 
The change is based on 97ce20a

I removed a few lines of code there which are already part of fetchMore()

Fixes: owncloud#7336
TheOneRing added a commit that referenced this issue Feb 11, 2020
@TheOneRing
Fix expansion of tree view on newly added accounts
8154e50 
The change is based on 97ce20a

I removed a few lines of code there which are already part of fetchMore()

Fixes: #7336
@michaelstingl
Copy link
Contributor

fixed

@TheOneRing TheOneRing mentioned this issue Apr 7, 2020
Closed
47 tasks
@HanaGemela HanaGemela mentioned this issue Apr 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheOneRing TheOneRing

Labels
Design & UX p2-high Escalation, on top of current planning, release blocker ReadyToTest QA, please validate the fix/enhancement type:bug
Projects
None yet
Milestone
2.6.0
Development

No branches or pull requests
4 participants
@TheOneRing @michaelstingl @ckamm @HanaGemela