Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] Renamed folder never propagates to windows client, when one file was locked #8766

Closed
jnweiger opened this issue Jun 21, 2021 · 2 comments
Closed

[QA] Renamed folder never propagates to windows client, when one file was locked #8766

jnweiger opened this issue Jun 21, 2021 · 2 comments

Comments

@jnweiger
Copy link
Contributor

jnweiger commented Jun 21, 2021 •
edited
Loading

Seen while testing #8763 with 2.8.3.4442

  • Connect a windows client to demo.owncloud.org using winVFS.
  • Open Documents/Example.odt with LibreOffice writer (no changes needed, just leave it open)
  • Use the server WebUI to rename the folder Documents to Dada.
  • The client correctly shows an error:
    image
  • Quit LibreOffice, wait.
06-21 11:25:17:576 [ info sync.accessmanager ]: 6 "PROPFIND" "https://demo.owncloud.org/remote.php/dav/files/demo/" has X-Request-ID "97a5f0d6-c429-445f-8535-934a05887a4d"
06-21 11:25:17:577 [ info sync.networkjob ]:    OCC::PropfindJob created for "https://demo.owncloud.org" + "/" "OCC::QuotaInfo"
06-21 11:25:18:063 [ info sync.networkjob.propfind ]:   PROPFIND of QUrl("https://demo.owncloud.org/remote.php/dav/files/demo/") FINISHED WITH STATUS "OK"
06-21 11:25:28:998 [ info sync.accessmanager ]: 6 "PROPFIND" "https://demo.owncloud.org/remote.php/dav/files/demo/" has X-Request-ID "8eca5506-09a3-4c9b-b64f-f36adb4c967b"
06-21 11:25:28:999 [ info sync.networkjob ]:    OCC::PropfindJob created for "https://demo.owncloud.org" + "/" "OCC::ConnectionValidator"
06-21 11:25:29:149 [ info sync.networkjob.propfind ]:   PROPFIND of QUrl("https://demo.owncloud.org/remote.php/dav/files/demo/") FINISHED WITH STATUS "OK"
06-21 11:25:47:267 [ info gui.folder ]: Trying to check "https://demo.owncloud.org/remote.php/dav/files/demo/" for changes via ETag check. (time since last sync: 42 s)
06-21 11:25:47:268 [ info sync.accessmanager ]: 6 "PROPFIND" "https://demo.owncloud.org/remote.php/dav/files/demo/" has X-Request-ID "2e9716b2-9abe-45d5-9522-d44b217ab1fc"
06-21 11:25:47:272 [ info sync.networkjob ]:    OCC::RequestEtagJob created for "https://demo.owncloud.org" + "/" "OCC::Folder"
06-21 11:25:47:467 [ info sync.networkjob.etag ]:       Request Etag of QUrl("https://demo.owncloud.org/remote.php/dav/files/demo/") FINISHED WITH STATUS "OK"
06-21 11:25:48:063 [ info sync.accessmanager ]: 6 "PROPFIND" "https://demo.owncloud.org/remote.php/dav/files/demo/" has X-Request-ID "1c799e65-555f-48d9-b17f-d8972dc3eb6b"
06-21 11:25:48:064 [ info sync.networkjob ]:    OCC::PropfindJob created for "https://demo.owncloud.org" + "/" "OCC::QuotaInfo"
06-21 11:25:48:203 [ info sync.networkjob.propfind ]:   PROPFIND of QUrl("https://demo.owncloud.org/remote.php/dav/files/demo/") FINISHED WITH STATUS "OK"
06-21 11:26:17:258 [ info gui.folder ]: Trying to check "https://demo.owncloud.org/remote.php/dav/files/demo/" for changes via ETag check. (time since last sync: 72 s)
06-21 11:26:17:261 [ info sync.accessmanager ]: 6 "PROPFIND" "https://demo.owncloud.org/remote.php/dav/files/demo/" has X-Request-ID "15e9302b-4ef3-4d9d-abc5-482990a43c9f"
06-21 11:26:17:261 [ info sync.networkjob ]:    OCC::RequestEtagJob created for "https://demo.owncloud.org" + "/" "OCC::Folder"
06-21 11:26:17:426 [ info sync.networkjob.etag ]:       Request Etag of QUrl("https://demo.owncloud.org/remote.php/dav/files/demo/") FINISHED WITH STATUS "OK"
06-21 11:26:18:203 [ info sync.accessmanager ]: 6 "PROPFIND" "https://demo.owncloud.org/remote.php/dav/files/demo/" has X-Request-ID "ad8a5d1f-759f-4afc-bfc4-b643ba2c8b30"
06-21 11:26:18:206 [ info sync.networkjob ]:    OCC::PropfindJob created for "https://demo.owncloud.org" + "/" "OCC::QuotaInfo"
06-21 11:26:18:351 [ info sync.networkjob.propfind ]:   PROPFIND of QUrl("https://demo.owncloud.org/remote.php/dav/files/demo/") FINISHED WITH STATUS "OK"
06-21 11:26:47:259 [ info gui.folder ]: Trying to check "https://demo.owncloud.org/remote.php/dav/files/demo/" for changes via ETag check. (time since last sync: 102 s)
06-21 11:30:58:063 [ info sync.accessmanager ]: 6 "PROPFIND" "https://demo.owncloud.org/remote.php/dav/files/demo/" has X-Request-ID "932d40a3-b979-44ed-83a8-cb850f4166f2"
06-21 11:30:58:077 [ info sync.networkjob ]:    OCC::PropfindJob created for "https://demo.owncloud.org" + "/" "OCC::QuotaInfo"
06-21 11:30:58:078 [ info sync.accessmanager ]: 6 "PROPFIND" "https://demo.owncloud.org/remote.php/dav/files/demo/" has X-Request-ID "7a162821-45d6-4c3b-bd4c-547cd8f27590"
06-21 11:30:58:078 [ info sync.networkjob ]:    OCC::PropfindJob created for "https://demo.owncloud.org" + "/" "OCC::ConnectionValidator"
06-21 11:30:58:079 [ info sync.accessmanager ]: 2 "" "https://demo.owncloud.org/ocs/v2.php/apps/notifications/api/v1/notifications?format=json" has X-Request-ID "b175430f-e287-4a0e-a3ab-fac754b8651e"
06-21 11:30:58:079 [ info sync.networkjob ]:    OCC::JsonApiJob created for "https://demo.owncloud.org" + "ocs/v2.php/apps/notifications/api/v1/notifications" "OCC::ServerNotificationHandler"
06-21 11:30:58:080 [ info sync.accessmanager ]: 6 "PROPFIND" "https://demo.owncloud.org/remote.php/dav/files/demo/" has X-Request-ID "cb0e89b6-a095-4d67-bc3d-0ea20ec35d94"
06-21 11:30:58:082 [ info sync.networkjob ]:    OCC::RequestEtagJob created for "https://demo.owncloud.org" + "/" "OCC::Folder"
06-21 11:30:58:859 [ info sync.networkjob.propfind ]:   PROPFIND of QUrl("https://demo.owncloud.org/remote.php/dav/files/demo/") FINISHED WITH STATUS "OK"
06-21 11:30:58:865 [ info sync.networkjob.etag ]:       Request Etag of QUrl("https://demo.owncloud.org/remote.php/dav/files/demo/") FINISHED WITH STATUS "OK"
06-21 11:30:58:901 [ info sync.networkjob.jsonapi ]:    JsonApiJob of QUrl("https://demo.owncloud.org/ocs/v2.php/apps/notifications/api/v1/notifications?format=json") FINISHED WITH STATUS "OK"
06-21 11:30:58:954 [ info sync.networkjob.propfind ]:   PROPFIND of QUrl("https://demo.owncloud.org/remote.php/dav/files/demo/") FINISHED WITH STATUS "OK"
06-21 11:31:17:336 [ info gui.folder ]: Trying to check "https://demo.owncloud.org/remote.php/dav/files/demo/" for changes via ETag check. (time since last sync: 372 s)
06-21 11:31:17:341 [ info sync.accessmanager ]: 6 "PROPFIND" "https://demo.owncloud.org/remote.php/dav/files/demo/" has X-Request-ID "3774a13a-9130-47b6-adc1-08c2e511252a"
06-21 11:31:17:341 [ info sync.networkjob ]:    OCC::RequestEtagJob created for "https://demo.owncloud.org" + "/" "OCC::Folder"
06-21 11:31:17:478 [ info sync.networkjob.etag ]:       Request Etag of QUrl("https://demo.owncloud.org/remote.php/dav/files/demo/") FINISHED WITH STATUS "OK"
06-21 11:31:28:888 [ info sync.accessmanager ]: 6 "PROPFIND" "https://demo.owncloud.org/remote.php/dav/files/demo/" has X-Request-ID "fd68cffc-3eae-4e95-aa58-3fdab983d90e"
06-21 11:31:28:897 [ info sync.networkjob ]:    OCC::PropfindJob created for "https://demo.owncloud.org" + "/" "OCC::QuotaInfo"
06-21 11:31:29:020 [ info sync.networkjob.propfind ]:   PROPFIND of QUrl("https://demo.owncloud.org/remote.php/dav/files/demo/") FINISHED WITH STATUS "OK"
06-21 11:31:47:345 [ info gui.folder ]: Trying to check "https://demo.owncloud.org/remote.php/dav/files/demo/" for changes via ETag check. (time since last sync: 402 s)
06-21 11:31:47:354 [ info sync.accessmanager ]: 6 "PROPFIND" "https://demo.owncloud.org/remote.php/dav/files/demo/" has X-Request-ID "3b274894-8f95-46a4-b1e1-544ac5537ac9"
06-21 11:31:47:356 [ info sync.networkjob ]:    OCC::RequestEtagJob created for "https://demo.owncloud.org" + "/" "OCC::Folder"
06-21 11:31:47:505 [ info sync.networkjob.etag ]:       Request Etag of QUrl("https://demo.owncloud.org/remote.php/dav/files/demo/") FINISHED WITH STATUS "OK"
06-21 11:31:59:041 [ info sync.accessmanager ]: 6 "PROPFIND" "https://demo.owncloud.org/remote.php/dav/files/demo/" has X-Request-ID "ac157982-64b4-422b-8961-7066d0e9a112"
06-21 11:31:59:044 [ info sync.networkjob ]:    OCC::PropfindJob created for "https://demo.owncloud.org" + "/" "OCC::QuotaInfo"
06-21 11:31:59:178 [ info sync.networkjob.propfind ]:   PROPFIND of QUrl("https://demo.owncloud.org/remote.php/dav/files/demo/") FINISHED WITH STATUS "OK"
06-21 11:32:17:348 [ info gui.folder ]: Trying to check "https://demo.owncloud.org/remote.php/dav/files/demo/" for changes via ETag check. (time since last sync: 432 s)
06-21 11:32:20:321 [ info sync.accessmanager ]: 6 "PROPFIND" "https://demo.owncloud.org/remote.php/dav/files/demo/" has X-Request-ID "7bdf0860-6272-4824-8163-5e9a1f26bc3d"
06-21 11:32:20:322 [ info sync.networkjob ]:    OCC::RequestEtagJob created for "https://demo.owncloud.org" + "/" "OCC::Folder"
06-21 11:32:20:474 [ info sync.networkjob.etag ]:       Request Etag of QUrl("https://demo.owncloud.org/remote.php/dav/files/demo/") FINISHED WITH STATUS "OK"
06-21 11:32:29:202 [ info sync.accessmanager ]: 6 "PROPFIND" "https://demo.owncloud.org/remote.php/dav/files/demo/" has X-Request-ID "7ebd3c18-7529-45a5-8ee8-cc7dfa75b2f2"
06-21 11:32:29:215 [ info sync.networkjob ]:    OCC::PropfindJob created for "https://demo.owncloud.org" + "/" "OCC::QuotaInfo"
06-21 11:32:29:331 [ info sync.networkjob.propfind ]:   PROPFIND of QUrl("https://demo.owncloud.org/remote.php/dav/files/demo/") FINISHED WITH STATUS "OK"

The client does not re-check the permissions. The error message remains visible.

Expected behaviour: As soon as the lock is gone, the client does the rename and the error message disappears.

Workaround: force sync now.
@jnweiger jnweiger changed the title [QA] Renamed folder never propagats to windows client, when one file is locked [QA] Renamed folder never propagates to windows client, when one file is locked Jun 21, 2021
@jnweiger jnweiger changed the title [QA] Renamed folder never propagates to windows client, when one file is locked [QA] Renamed folder never propagates to windows client, when one file was locked Jun 21, 2021
@jnweiger
Copy link
Contributor Author

Without doing a Force-sync-now:
When the user opens another virtual file (e.g. click open Photos/Portugal.jpg), the error message disappears.
This only removes the message from the UI. But the rename of the Documents folder is still pending.

Force-sync-now or client restart is required.

TheOneRing added a commit that referenced this issue Jun 22, 2021
@TheOneRing
Check a wehter file is locked before we move
b60b543 
Fixes: #8765, #8766
@TheOneRing TheOneRing mentioned this issue Jun 22, 2021
Merged
TheOneRing added a commit that referenced this issue Jun 22, 2021
@TheOneRing
Check a wehter file is locked before we move
792dcf9 
Fixes: #8765, #8766
TheOneRing added a commit that referenced this issue Jun 22, 2021
@TheOneRing
Check a wehter file is locked before we move
6a59a05 
Fixes: #8765, #8766
TheOneRing added a commit that referenced this issue Jun 22, 2021
@TheOneRing
Check a wehter file is locked before we move
bbbc1eb 
Fixes: #8765, #8766
TheOneRing added a commit that referenced this issue Jun 22, 2021
@TheOneRing
Check a wehter file is locked before we move
650be8b 
Fixes: #8765, #8766
TheOneRing added a commit that referenced this issue Jun 22, 2021
@TheOneRing
Check a wehter file is locked before we move
a9a9d07 
Fixes: #8765, #8766
@TheOneRing
Copy link
Contributor

Fixed in a9a9d07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheOneRing @jnweiger