Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression use of legacy settings location #8824

Closed
TheOneRing opened this issue Jul 16, 2021 · 2 comments · Fixed by #8860
Closed

Regression use of legacy settings location #8824

TheOneRing opened this issue Jul 16, 2021 · 2 comments · Fixed by #8860
Assignees
@TheOneRing
Labels
p2-high Escalation, on top of current planning, release blocker
Milestone
2.9.0

Comments

@TheOneRing
Copy link
Contributor

TheOneRing commented Jul 16, 2021 •
edited
Loading

Testpilot cloud now falls back to the legacy location C:\Users\hanna\AppData\Roaming\testpilotcloud....

Introduced in #8670

The migration in https://github.com/owncloud/client/blob/master/src/gui/application.cpp#L171 was broken since the first day as
https://github.com/owncloud/client/blob/master/src/libsync/configfile.cpp#L112 was setting the legacy name each time the constructor is called.

TODO:

  • Remove all calls to setApplicationName besides the main one in Application.
  • Implement an additional migration path to the short name location.
@TheOneRing TheOneRing self-assigned this Jul 16, 2021
@TheOneRing TheOneRing added this to the 2.9.0 milestone Jul 16, 2021
@TheOneRing TheOneRing added the p2-high Escalation, on top of current planning, release blocker label Jul 16, 2021
@fmoc fmoc mentioned this issue Aug 2, 2021
Merged
fmoc pushed a commit that referenced this issue Aug 6, 2021
Add changelog item for #8824
490718b
fmoc pushed a commit that referenced this issue Aug 6, 2021
@fmoc
Add changelog item for #8824
4b93bce
@fmoc
Copy link
Contributor

fmoc commented Aug 6, 2021

Fixed in #8860.

@fmoc fmoc closed this as completed Aug 6, 2021
dragotin pushed a commit that referenced this issue Aug 10, 2021
Add changelog item for #8824
afe2bfc
@jnweiger jnweiger mentioned this issue Aug 23, 2021
Closed
20 tasks
@jnweiger
Copy link
Contributor

Confirmed fixed in 2.9.0 beta3

On a system, with running 2.7.2, the newly installed client says Migrating old config from "/home/testy/.config/ownCloud Testpilot Edition" to "/home/testy/.config/testpilotcloud"
And it creates a symlink, so that nothing bad happens, while the old binary still runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheOneRing TheOneRing

Labels
p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Milestone
2.9.0
Development

Successfully merging a pull request may close this issue.

Fix config data migration from 2.8 to 2.9 owncloud/client
3 participants
@TheOneRing @jnweiger @fmoc