Fix overall status computation #10536
Conversation
src/gui/folderman.cpp
Outdated
| } | ||
| break; | ||
| auto status = f->syncPaused() ? SyncResult::Paused : f->syncResult().status(); | ||
| if (SyncResult::Undefined) { |
There was a problem hiding this comment.
You probably want to compare against status.
|
Before status done was taking precedence over status in progress |
| status = SyncResult::Problem; | ||
| } | ||
| if (status > _overallStatus.status()) { | ||
| _overallStatus.setStatus(status); |
There was a problem hiding this comment.
This somehow looks as if the status can never go to "lower" values any more, because of the if statement. In the code before it could. Or is it reset elsewhere again?
There was a problem hiding this comment.
The commutation happens on a temporary so we always start with undefined.
There was a problem hiding this comment.
Undefined is currently the smallest value. The order is documented above the definition. This should be fine.
TheOneRing
force-pushed
the
work/overall_status
branch
from
f2b3418 to
eba85e4
Compare
|
Kudos, SonarCloud Quality Gate passed! |
| status = SyncResult::Problem; | ||
| } | ||
| if (status > _overallStatus.status()) { | ||
| _overallStatus.setStatus(status); |
There was a problem hiding this comment.
Undefined is currently the smallest value. The order is documented above the definition. This should be fine.
Please read carefully, I'm not sure what the whole logic here was meant to do (It`s my code).
Fixes: #9270