Move OAuth dialog to HttpCredentialsGui #11478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where askFromUser did not display a ui and the client got stuck in reconnecting
TheOneRing
force-pushed
the
work/oauth2
branch
from
4410bf9 to
d66991b
Compare
fmoc
previously approved these changes
Jan 17, 2024
|
Looks good to me. I've just got some feedback on the wording. |
Co-authored-by: Fabian Müller <[email protected]>
fmoc
approved these changes
Jan 17, 2024
|
Steps to test the fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where askFromUser did not display a ui and the client got stuck in reconnecting