Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Remove all dialog #11570

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Remove Remove all dialog #11570

merged 1 commit into from
Apr 4, 2024

Conversation

TheOneRing
Copy link
Contributor

Fixes: #7304
Fixes: #11569

@TheOneRing TheOneRing requested review from erikjv and tbsbdr April 2, 2024 14:58
tbsbdr
tbsbdr reviewed Apr 3, 2024
View reviewed changes
Copy link

@tbsbdr tbsbdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't judge on the code, but I can give my approval to have some skin in the game

@TheOneRing TheOneRing merged commit 4aea056 into master Apr 4, 2024
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the work/remove_all2 branch April 4, 2024 14:36
@saw-jan saw-jan mentioned this pull request Apr 5, 2024
Merged
@saw-jan saw-jan mentioned this pull request Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbsbdr tbsbdr tbsbdr left review comments

@erikjv erikjv erikjv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the remove all dialog Remove all files message is too complicated
3 participants
@TheOneRing @erikjv @tbsbdr