Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focusing the first/last item in a qtquickwidget #11715

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

TheOneRing
Copy link
Contributor

No description provided.

@TheOneRing TheOneRing requested a review from erikjv June 21, 2024 12:29
@TheOneRing TheOneRing linked an issue Jun 21, 2024 that may be closed by this pull request
@erikjv
Copy link
Collaborator

erikjv commented Jun 21, 2024

Mac: ok
Windows: I cannot see where the focus goes after the "Add Space" button.

Also: I noticed that when there is an account-modal dialog (i.e. I was logged out, and the login "dialog" was showing), it wasn't very clear that I couldn't interact with the toolbar. Maybe that should be grayed out a bit? (Same with the high-contrast theme.)

erikjv
erikjv previously approved these changes Jun 21, 2024
@TheOneRing
Copy link
Contributor Author

erikjv
erikjv previously approved these changes Jun 24, 2024
@TheOneRing TheOneRing force-pushed the work/continuous_focus branch from 8867749 to 1f8190a Compare June 24, 2024 15:36
@TheOneRing TheOneRing enabled auto-merge (rebase) June 24, 2024 15:37
@TheOneRing TheOneRing disabled auto-merge June 24, 2024 16:55
@TheOneRing TheOneRing merged commit 890d7f0 into master Jun 24, 2024
7 checks passed
@TheOneRing TheOneRing deleted the work/continuous_focus branch June 24, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backtab navigation to qml elements does not behave as aexpected
2 participants