Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add sync connections for new discovered spaces #11774

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

erikjv
Copy link
Collaborator

@erikjv erikjv commented Aug 1, 2024

For now, this can only be enabled through theming.

Fixes: #11751

@erikjv erikjv added the p1-urgent Consider a hotfix release with only that fix (ex: lose trust, money, security issue, ...) label Aug 1, 2024
@erikjv erikjv added this to the Desktop 6.0 milestone Aug 1, 2024
@erikjv erikjv requested a review from TheOneRing August 1, 2024 16:06
@erikjv erikjv self-assigned this Aug 1, 2024
@erikjv erikjv force-pushed the work/auto-sync-new-spaces branch from c62aaec to cf49058 Compare August 5, 2024 14:19
@erikjv erikjv requested a review from TheOneRing August 5, 2024 14:20
@erikjv erikjv removed this from the Desktop 6.0 milestone Aug 5, 2024
Copy link
Contributor

@TheOneRing TheOneRing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog item

erikjv added 3 commits August 19, 2024 20:29
For now, this can only be enabled through theming.

Fixes: #11751
It is now used outside the folder wizard to create sync connections by
the folder manager. So now it is `FolderMan::SyncConnectionDescription`.
@erikjv erikjv force-pushed the work/auto-sync-new-spaces branch from 190c9f1 to fcb9dce Compare August 19, 2024 18:30
@erikjv erikjv requested a review from TheOneRing August 19, 2024 18:30
@TheOneRing TheOneRing merged commit fa6f7a0 into master Aug 20, 2024
5 of 6 checks passed
@TheOneRing TheOneRing deleted the work/auto-sync-new-spaces branch August 20, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-urgent Consider a hotfix release with only that fix (ex: lose trust, money, security issue, ...)
Projects
None yet
2 participants