Sharing: Optionally show warning that links are public #5747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michaelstingl @pmaier1 Looks ok? Now in retrospect I'm thinking maybe this message should be default? |
You are right. In this view it don't hurt too much. |
|
Slightly changed plan: We will get a capability for this on the server side. Then we don't need a ownBrander option.(see https://github.com/owncloud/enterprise/issues/1914#issuecomment-299157208) |
pmaier1
previously approved these changes
May 4, 2017
guruz
force-pushed
the
linkSharingShowWarningLinksArePublic
branch
from
f698f94 to
0c22e12
Compare
ckamm
approved these changes
May 9, 2017
ckamm
added a commit
that referenced
this pull request
May 22, 2017
guruz
pushed a commit
that referenced
this pull request
May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/owncloud/enterprise/issues/1914