Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix branded nemo and caja shell integration #5966

Merged
merged 3 commits into from
Aug 31, 2017
Merged

Conversation

jnweiger
Copy link
Contributor

The APPLICATION_SHORTNAME only made it into the nautilus copy of syncstate.py so far.
Now caja and nemo also recieve a branded copy. Correct branding is important for a nemo plugin, because this is part of the socket name that we need for connecting.

@guruz guruz requested a review from ogoffart August 16, 2017 09:38
@guruz guruz added this to the 2.4.0 milestone Aug 16, 2017
@guruz guruz requested review from ckamm and dragotin August 16, 2017 09:39
@guruz
Copy link
Contributor

guruz commented Aug 25, 2017

Looks OK to me, although I would prefer someone with Linux to review this too..

@jnweiger feel free to merge..

@@ -1,7 +1,7 @@
#!/bin/sh

# this script creates a plugin for caja, just by replacing
# all occurences of Nautilus with Caja (case sensitive).
# all occurences of Nautilus with Caja (case sensitive).X
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you should rebase to get rid of this commit.

@ogoffart ogoffart merged commit 8393615 into master Aug 31, 2017
@ogoffart ogoffart deleted the jnweiger-patch-2 branch August 31, 2017 11:16
@ogoffart
Copy link
Contributor

I squashed and merged.

@jnweiger
Copy link
Contributor Author

jnweiger commented Sep 3, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants