Windows: Integrate with the navigation pane #6113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
reviewed
Oct 23, 2017
|
Maybe create a new WindowPaneHelper class, so you can move the code away from folderman? |
|
@jturcotte this is super cool! 🔝 Screenshots for ref:
|
|
@CorneelDragon @haukman FYI ^ |
|
@michaelstingl Looks great! Thanks for the work and the update 👍 |
|
awesome! :) Thanks @jturcotte |
jturcotte
force-pushed
the
explorer-navigation-pane
branch
from
4372297 to
a790601
Compare
This is only the navigation pane, the SyncRootManager entries aren't handled yet. This follows the instructions from: https://msdn.microsoft.com/en-us/library/windows/desktop/dn889934%28v=vs.85%29.aspx Issue #5295
… integration Issue #5295
jturcotte
force-pushed
the
explorer-navigation-pane
branch
from
a790601 to
14f19a4
Compare
|
@ogoffart Moved to a |
ogoffart
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only activated on Windows 10 and later and only include the navigation pane part of
https://msdn.microsoft.com/en-us/library/windows/desktop/dn889934%28v=vs.85%29.aspx
The "sync root provider" section still has to be done, which I suspect is what allows Microsoft
Office to display the cloud storage entry in its file management dialog.
Issue #5295