Sharing: fix overlay icons directly after sharing a file #6115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is growing indefinitively in case of error, causing a leak. Use a labda instead to pass the capture
It is unused.
... even if the file is not changed. We get an UPDATE_METADATA in that case, so make sure we let the SyncFileStatusTracker know about it. That means we need to filter out UPDATE_METADATA in the other listeners of this signal. Issue #6098
This allow the sync engine to query the new metadata and update the overlay icons. Note: we also need to invalidate the etags because the server does not change the etag of parent directories that see their share-types changed. Issue #6098
jturcotte
reviewed
Oct 23, 2017
| if (item->_instruction == CSYNC_INSTRUCTION_NONE || item->_instruction == CSYNC_INSTRUCTION_UPDATE_METADATA) { | ||
| // We only care about the updates that deserve to be shown in the UI | ||
| return; | ||
| } |
There was a problem hiding this comment.
Including CSYNC_INSTRUCTION_NONE sounds wrong, would it be possible to check at the emit point?
There was a problem hiding this comment.
CSYNC_INSTRUCTION_NONE should never happen. But i'm putting it there as it goes hand to hand with UPDATE_METADATA. (Should the sync engine change, and emit the signal with CSYNC_INSTRUCTION_NONE in the future, we probably want to filter it there anyway)
I could remove it from this check if you think this is confusing.
jturcotte
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message for more information.
The two first commit are just code cleanup
The other commit fix the issue #6098
This include a workaround of the fact that the server don't update the etags.