Discovery: Windows: Don't check if a server file name can be encoded #6820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckamm
approved these changes
Oct 18, 2018
| @@ -147,7 +148,7 @@ static int _csync_detect_update(CSYNC *ctx, std::unique_ptr<csync_file_stat_t> f | |||
| } | |||
|
|
|||
| auto localCodec = QTextCodec::codecForLocale(); | |||
| if (ctx->current == REMOTE_REPLICA && localCodec->mibEnum() != 106) { | |||
| if (!OCC::Utility::isWindows() && ctx->current == REMOTE_REPLICA && localCodec->mibEnum() != 106) { | |||
There was a problem hiding this comment.
Please add a comment about why windows is excluded.
Because on windows, all filename can be encoded: The file system uses UTF-16, regardless of the locale Issue: #6810
mgallien
added a commit
to nextcloud/desktop
that referenced
this pull request
Aug 14, 2023
inspired by owncloud/client#6820 Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
added a commit
to nextcloud/desktop
that referenced
this pull request
Aug 16, 2023
inspired by owncloud/client#6820 Close #5935 Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
added a commit
to nextcloud/desktop
that referenced
this pull request
Aug 17, 2023
inspired by owncloud/client#6820 Close #5935 Signed-off-by: Matthieu Gallien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because on windows, all filename can be encoded: The file system uses
UTF-16, regardless of the locale
Issue: #6810