Fix discovery getting stuck on 403/503 reply on root item #7136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if one set the instruction to ERROR while forgetting to set an error status, it'd propagate as FileIgnored. Now the default is NormalError for INSTRUCTION_ERROR and FileIgnored for INSTRUCTION_IGNORE.
ogoffart
approved these changes
Apr 11, 2019
Previously these result codes during remote discovery of the sync root would not cause an error and the discovery would get stuck. Also extends RemoteDiscovery tests to check for errors on the root item.
ckamm
force-pushed
the
discovery-error-on-root
branch
from
3a34640 to
c4837a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRing the cleanups/test additions from #7134