Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential null pointer access #7760

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Fix potential null pointer access #7760

merged 1 commit into from
Feb 24, 2020

Conversation

TheOneRing
Copy link
Contributor

@TheOneRing TheOneRing requested a review from ogoffart February 24, 2020 08:45
@ogoffart
Copy link
Contributor

I don't see how this could be related to the linked crash.

@TheOneRing
Copy link
Contributor Author

@ogoffart

client/src/libsync/discoveryphase.cpp

Line 218 in 68c6d85

if (_currentRootJob && _currentlyActiveJobs < limit) {

@ogoffart
Copy link
Contributor

Ah yes, maybe it is related

@TheOneRing TheOneRing merged commit d4f834b into owncloud:2.6 Feb 24, 2020
@TheOneRing TheOneRing deleted the crash branch February 24, 2020 09:05
@ogoffart
Copy link
Contributor

Note that the stack trace has a QDialog::exec() and re-enter the event loop (so maybe some event are not processed in the order we would expect them)

@TheOneRing
Copy link
Contributor Author

I left a note in #7304

@TheOneRing TheOneRing mentioned this pull request Apr 7, 2020
Closed
47 tasks
@HanaGemela HanaGemela mentioned this pull request Apr 29, 2020
Closed
@HanaGemela
Copy link
Contributor

@TheOneRing please provide test to recreate

@TheOneRing
Copy link
Contributor Author

I don't think this one can be tested manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogoffart ogoffart ogoffart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheOneRing @ogoffart @HanaGemela