Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Client sometimes does not show up when started by a user #7784

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

TheOneRing
Copy link
Contributor

Issue: #7018

@TheOneRing TheOneRing requested review from ogoffart and jnweiger March 3, 2020 12:59
Copy link
Contributor

@ogoffart ogoffart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but is that really the behavior we want?
Opening the settings dialog every time one starts owncloud?

@@ -1,7 +1,7 @@
[Desktop Entry]
Categories=Utility;X-SuSE-SyncUtility;
Type=Application
Exec=@APPLICATION_EXECUTABLE@
Exec=@APPLICATION_EXECUTABLE@ --showsettings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why do we want to show the settings dialog when starting owncloud from the menu?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it gives the user a feedback that something happened.
I'd also expect 99% of the users to have it in autostart.

@jnweiger
Copy link
Contributor

jnweiger commented Mar 3, 2020

Tested on Linux Mint 19

  • Double click on the desktop icon always immedately opens the settings windows. Regardless, if the client was previously running or not. OK.
  • Starting the client from the command line does not open the settings dialog. OK
  • Repeatedly calling the command line client within the first 10 seconds also does nothing. OK
  • Calling the client from the commandline after 10 seconds opens the settings menu. OK

logout / login:

  • the client does autostart wihtout showing the settings. The tray icon appears. OK
  • clicking the desktop icon shortly after the tray icon appears, immediately opens the settings window. OK
  • calling the command line client immediately after the tray icon appears does nothing. OK.
  • the state of the client at logout (stopped, running, running with settings open) has no impact on the next autostart. OK.

Copy link
Contributor

@jnweiger jnweiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@TheOneRing TheOneRing merged commit 9cac0da into owncloud:2.6 Mar 4, 2020
@TheOneRing TheOneRing deleted the dont_delay branch March 4, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants